From owner-svn-src-head@FreeBSD.ORG Wed Oct 17 15:19:38 2012 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B0AAE63D; Wed, 17 Oct 2012 15:19:38 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 6DE398FC08; Wed, 17 Oct 2012 15:19:37 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA07253; Wed, 17 Oct 2012 18:19:34 +0300 (EEST) (envelope-from avg@FreeBSD.org) Message-ID: <507ECC86.4080503@FreeBSD.org> Date: Wed, 17 Oct 2012 18:19:34 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:16.0) Gecko/20121012 Thunderbird/16.0.1 MIME-Version: 1.0 To: Nikolay Denev , John Baldwin Subject: Re: svn commit: r237656 - in head: contrib/top usr.bin/top References: <201206271808.q5RI8m0d024853@svn.freebsd.org> <38E42006-48A5-4AF7-9892-EB81583FE5A9@gmail.com> In-Reply-To: <38E42006-48A5-4AF7-9892-EB81583FE5A9@gmail.com> X-Enigmail-Version: 1.4.5 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2012 15:19:38 -0000 on 17/10/2012 18:04 Nikolay Denev said the following: > It looks like MFU and MRU are swapped in top's display. > > I'm using this to correct the output: > > --- /usr/src/.zfs/snapshot/patches/usr.bin/top/machine.c 2012-09-26 08:20:26.000000000 +0200 > +++ usr.bin/top/machine.c 2012-10-17 17:00:14.988895167 +0200 > @@ -515,9 +515,9 @@ > if (arc_enabled) { > GETSYSCTL("kstat.zfs.misc.arcstats.size", arc_stat); > arc_stats[0] = arc_stat >> 10; > - GETSYSCTL("vfs.zfs.mfu_size", arc_stat); > - arc_stats[1] = arc_stat >> 10; > GETSYSCTL("vfs.zfs.mru_size", arc_stat); > + arc_stats[1] = arc_stat >> 10; > + GETSYSCTL("vfs.zfs.mfu_size", arc_stat); > arc_stats[2] = arc_stat >> 10; > GETSYSCTL("vfs.zfs.anon_size", arc_stat); > arc_stats[3] = arc_stat >> 10; Good catch! Indeed. -- Andriy Gapon