From owner-cvs-all@FreeBSD.ORG Sun Jul 3 01:03:22 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 89DFE16AA06; Sun, 3 Jul 2005 00:57:23 +0000 (GMT) (envelope-from ps@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 429B54417A; Sun, 3 Jul 2005 00:38:53 +0000 (GMT) (envelope-from ps@mu.org) Received: by elvis.mu.org (Postfix, from userid 1000) id 11C016D9A2; Sat, 2 Jul 2005 17:37:40 -0700 (PDT) X-Original-To: ps@mu.org Delivered-To: ps@mu.org Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by elvis.mu.org (Postfix) with ESMTP id 09D1E5CA03 for ; Mon, 17 Jan 2005 18:48:09 -0800 (PST) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id 081F856CAF for ; Tue, 18 Jan 2005 02:48:07 +0000 (GMT) (envelope-from owner-src-committers@FreeBSD.org) Received: by hub.freebsd.org (Postfix) id CF0C316A539; Tue, 18 Jan 2005 02:48:01 +0000 (GMT) Delivered-To: ps@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 538) id 3700216A4D1; Tue, 18 Jan 2005 02:47:59 +0000 (GMT) Delivered-To: src-committers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 00E8616A4CF for ; Tue, 18 Jan 2005 02:47:57 +0000 (GMT) Received: from mail13.speakeasy.net (mail21.sea5.speakeasy.net [69.17.117.23]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6BA4943D48 for ; Tue, 18 Jan 2005 02:47:56 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 32395 invoked from network); 18 Jan 2005 02:47:56 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail13.speakeasy.net (qmail-ldap-1.03) with AES256-SHA encrypted SMTP for ; 18 Jan 2005 02:47:55 -0000 Received: from slimer.baldwin.cx (slimer.baldwin.cx [192.168.0.16]) (authenticated bits=0) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id j0I2lqaF092340; Mon, 17 Jan 2005 21:47:52 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Mike Silbersack User-Agent: KMail/1.6.2 References: <200501170756.j0H7uSU9031593@repoman.freebsd.org> In-Reply-To: <200501170756.j0H7uSU9031593@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200501172034.43213.jhb@FreeBSD.org> Sender: owner-src-committers@FreeBSD.org Precedence: bulk X-Loop: FreeBSD.ORG X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on elvis.mu.org X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.1 X-Spam-Level: Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sys_pipe.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 03 Jul 2005 01:03:22 -0000 X-Original-Date: Mon, 17 Jan 2005 20:34:43 -0500 X-List-Received-Date: Sun, 03 Jul 2005 01:03:22 -0000 On Monday 17 January 2005 02:56 am, Mike Silbersack wrote: > silby 2005-01-17 07:56:28 UTC > > FreeBSD src repository > > Modified files: > sys/kern sys_pipe.c > Log: > Rearrange the kninit calls for both directions of a pipe so that > they both happen before pipe backing allocation occurs. Previously, > a pipe memory shortage would cause a panic due to a KNOTE call > on an uninitialized si_note. > > Reported by: Peter Holm > MFC after: 1 week Good catch! -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org