From nobody Wed Jun 3 20:18:48 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gVzYR5vrpz6gdn1; Wed, 03 Jun 2026 20:18:51 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gVzYR5HY4z3D0x; Wed, 03 Jun 2026 20:18:51 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780517931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1zcJgxjIKE+spf8gRxTI63uCj1YzpGDm2MYLUsfYmBw=; b=fmKhuxqfb2EpbIbeAKRF5vC9ej00Jovu8ZiM76kB9j5bHsRQDgyDlr9XVwhrHz64gYCnyO GZ/iAF/AMLos3HBkf7xCBXfeGE1AhGr3AGfIK0WawfsWXh83aHEci+EbmNu/Q1kU/BXtJ+ 9qSNFgDRR9iX56sRy10do239y1UdWxmFm2IfT5WwsPuIpa2wOTH5i64NDAMm0A/BNnUhFF TAYK0cqRVc0d/L4zGjqLtD061Lf7WcVLpRmvE01fV63mwZ3YukkPW0llMjsOA8bYCfGUvK yRYydfYULz80j0IdVthGYLl14p+rvZsjpWH07RX96VA4dE6WfS8R/AD4u/OOsw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780517931; a=rsa-sha256; cv=none; b=O3yHgBbDBmrAg0a+PWZU5lxoszfheZCqqWwu5/T8rGN5S8TY170GiLIzdOdljibrdwiO/A GwLU/pRjySob4m01lHvvfp7pWo8p0YGe9sUTy9d/DzmvN3UPh7tgI8r9JQIhcSYDuutd/o T7oRn0utfk3rwpL/MTCtbuIk2/MIoLFrJArpDkvTyxi/oPo9Q2bCT5/qpbmXUI30t+GU34 agOCu6JbhUG6jJ3NgjXpzeQPxWAqmiTqvJJgUEsZuer/rFLY57MWdtrbFapTKTe9Upj4F7 kOkdFE2CCGSS34L1Gvb1pmkaDMvGajI0AGOBRnwrBmSzW09XlNRRsFzXSIsz7A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780517931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1zcJgxjIKE+spf8gRxTI63uCj1YzpGDm2MYLUsfYmBw=; b=FopvEuf8ZXIOubjoc9k8sWdwl2DJ4IxuJ4Eei4x+0YgOW8AhIM0GJ0Cu5ORBdUiA7KfT9F TJDMlhxOthYES1z22f0iUHMWtt2e3w7snWuESfLAmk/kHu9gaargI4UIC1qr9PEUktMTin wdJu08JDkt10eHOFRWoEgAxxQIsKBTzYhmnf3h9oGgu2Ic38YV8kHOggXtj/EZsp23UNeG pDzWeqKCbhMPFRr4obJPhT3S5luo9bxKGxzm4+Q0YN+bHBd1MB0gM5EB6miOkc12QDh3TT 8f+PLgOHJdGXzSl+8/+q18V9altyheMHfxeIcQGaGF9uCiOk7OLfvwuxrRLRxw== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R12" (not verified)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gVzYR3mgQzPNB; Wed, 03 Jun 2026 20:18:51 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 9A50016BE3; Wed, 03 Jun 2026 22:18:49 +0200 (CEST) From: Kristof Provost To: Gleb Smirnoff Cc: Ishan Agrawal , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 017690e50913 - main - netpfil: add PF netlink command decoding support Date: Wed, 03 Jun 2026 22:18:48 +0200 X-Mailer: MailMate (2.0r6272) Message-ID: <03F81E99-0A9B-4265-951B-0177AC8ADA80@FreeBSD.org> In-Reply-To: References: <6a2028fd.30559.3287a30@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; markup=markdown Content-Transfer-Encoding: quoted-printable On 3 Jun 2026, at 22:08, Gleb Smirnoff wrote: > On Wed, Jun 03, 2026 at 01:15:41PM +0000, Kristof Provost wrote: > K> The branch main has been updated by kp: > K> > K> URL: https://cgit.FreeBSD.org/src/commit/?id=3D017690e509134422dbfa8= 0316eab56d8d3f87065 > K> > K> commit 017690e509134422dbfa80316eab56d8d3f87065 > K> Author: Ishan Agrawal > K> AuthorDate: 2026-06-01 12:24:05 +0000 > K> Commit: Kristof Provost > K> CommitDate: 2026-06-03 08:52:06 +0000 > K> > K> netpfil: add PF netlink command decoding support > K> > K> Convert PFNL_CMD values in pf_nl.h from an enum to #define const= ants, > K> add a pfnl_cmd table definition for mktable, and implement the > K> corresponding command decoding helpers in libsysdecode. > K> > K> This allows mktable to generate PF netlink command lookup tables= and > K> enables symbolic decoding of PF netlink commands. > K> > K> Reviewed by: kp > K> Signed-off-by: Ishan Agrawal > K> Sponsored by: Google LLC (GSoC 2026) > > Sorry for not reviewing in time. I got question: why does this > require ditching the enum and regressing down to preprocessor > defines? > The mktables script in libsysdecode expects to work on defines: https://g= ithub.com/freebsd/freebsd-src/blob/07d733963ecd1957999f5381b438b8c3696867= 50/lib/libsysdecode/mktables#L76 It=E2=80=99s possible to change that, but this being an enum doesn=E2=80=99= t really buy us much either, and this was the less invasive path. Best regards, Kristof