From owner-cvs-all  Tue Aug 27 21:45: 9 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E639037B400; Tue, 27 Aug 2002 21:45:03 -0700 (PDT)
Received: from InterJet.dellroad.org (adsl-63-194-81-26.dsl.snfc21.pacbell.net [63.194.81.26])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4FE4A43E3B; Tue, 27 Aug 2002 21:45:03 -0700 (PDT)
	(envelope-from archie@dellroad.org)
Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.1.1.20])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id VAA47279;
	Tue, 27 Aug 2002 21:41:48 -0700 (PDT)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.11.6/8.11.6) id g7S4ehj41931;
	Tue, 27 Aug 2002 21:40:43 -0700 (PDT)
	(envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200208280440.g7S4ehj41931@arch20m.dellroad.org>
Subject: Re: cvs commit: src/usr.sbin/ppp bundle.c ccp.c command.c datalink.c
         filter.c hdlc.c iface.c ipcp.c ipv6cp.c lcp.c link.c main.c mbuf.c 
        mp.c nat_cmd.c ncp.c physical.c prompt.h radius.c ro
In-Reply-To: <20020828130240.P2884-100000@gamplex.bde.org> "from Bruce Evans
 at Aug 28, 2002 01:20:47 pm"
To: Bruce Evans <bde@zeta.org.au>
Date: Tue, 27 Aug 2002 21:40:43 -0700 (PDT)
Cc: Brian Somers <brian@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
X-Mailer: ELM [version 2.4ME+ PL88 (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Bruce Evans writes:
> >   Include the correct file (stdarg.h) and use va_list rather than _BSD_VA_LIST_
> 
> This is hardly cleaner.  Now almost every .c file has to include <stdarg.h>
> to support a detail in prompt.h, despite only 2 .c files actually using that
> detail.  Those 2 already included <stdarg.h>.

But this is the way of C programming. I've lamented this same fact
many times in the past, but it's unavoidable unless you want to
put the "#include <stdarg.h>" inside prompt.h, which is a practice
generally frowned upon. If only C were Java... :-)

-Archie

__________________________________________________________________________
Archie Cobbs     *     Packet Design     *     http://www.packetdesign.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message