From owner-cvs-sys  Tue Apr 29 19:15:14 1997
Return-Path: <owner-cvs-sys>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id TAA25992
          for cvs-sys-outgoing; Tue, 29 Apr 1997 19:15:14 -0700 (PDT)
Received: from nasu.utsunomiya-u.ac.jp (nasu.utsunomiya-u.ac.jp [160.12.128.3])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id TAA25891;
          Tue, 29 Apr 1997 19:14:33 -0700 (PDT)
Received: from outmail.utsunomiya-u.ac.jp (outmail.utsunomiya-u.ac.jp [160.12.196.3]) by nasu.utsunomiya-u.ac.jp (8.8.4+2.7Wbeta4/3.5Wpl3) with ESMTP id LAA26206; Wed, 30 Apr 1997 11:14:03 +0900 (JST)
Received: from zodiac.mech.utsunomiya-u.ac.jp (DV5XFaX//bYT2u+pXWzlueIctgVJKAfp@zodiac.mech.utsunomiya-u.ac.jp [160.12.33.1]) by outmail.utsunomiya-u.ac.jp (8.8.4+2.7Wbeta4/3.5Wpl3) with ESMTP id LAA19527; Wed, 30 Apr 1997 11:14:02 +0900 (JST)
Received: from zodiac.mech.utsunomiya-u.ac.jp (zenith.mech.utsunomiya-u.ac.jp [160.12.33.60]) by zodiac.mech.utsunomiya-u.ac.jp (8.7.6+2.6Wbeta7/3.4W/zodiac-May96) with ESMTP
	id LAA23808; Wed, 30 Apr 1997 11:18:52 +0900 (JST)
Message-Id: <199704300218.LAA23808@zodiac.mech.utsunomiya-u.ac.jp>
To: "Andrey A. Chernov" <ache@freefall.freebsd.org>
cc: CVS-committers@freebsd.org, cvs-all@freebsd.org, cvs-sys@freebsd.org,
        yokota@zodiac.mech.utsunomiya-u.ac.jp
Subject: Re: cvs commit: src/sys/i386/isa syscons.c 
In-reply-to: Your message of "Tue, 29 Apr 1997 18:19:22 MST."
             <199704300119.SAA02530@freefall.freebsd.org> 
References: <199704300119.SAA02530@freefall.freebsd.org> 
Date: Wed, 30 Apr 1997 11:18:51 +0900
From: Kazutaka YOKOTA <yokota@zodiac.mech.utsunomiya-u.ac.jp>
Sender: owner-cvs-sys@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

>ache        97/04/29 18:19:22
>
>  Modified:    sys/i386/isa  syscons.c
>  Log:
>  In comp_vgaregs skip cursor shape and 4 unused bytes (6 total)
>  instead of 2 unused.

Unused?

I skipped the cursor position registers (CRTC registers 14 and 15). 
You skipped the cursor shape registers (CRTC registers 10 and 11) and
the start address registers (CRTC registers 12 and 13).

I agree that the cursor shape registers and the start address
registers may be set differently from the video mode parameter table
when the register values are read in scinit(). So, I don't object
skipping them when comparing register values in order to make some VGA
cards work.

But, these registers ARE used to set up the card, aren't they?

Kazu

>  Previus code broke syscons on Diamond Stealth 3D 3000
>  (video mode ptr was NULL with no real reason)
>  
>  Revision  Changes    Path
>  1.212     +4 -4      src/sys/i386/isa/syscons.c