From owner-cvs-src@FreeBSD.ORG  Sat Jul 29 06:14:33 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AF04516A4DD;
	Sat, 29 Jul 2006 06:14:33 +0000 (UTC)
	(envelope-from stefan@fafoe.narf.at)
Received: from viefep18-int.chello.at (viefep13-int.chello.at [213.46.255.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1CA4943D45;
	Sat, 29 Jul 2006 06:14:31 +0000 (GMT)
	(envelope-from stefan@fafoe.narf.at)
Received: from viefep31-int.chello.at ([213.47.85.26])
	by viefep18-int.chello.at
	(InterMail vM.6.01.05.04 201-2131-123-105-20051025) with ESMTP id
	<20060729061429.FONF2056.viefep18-int.chello.at@viefep31-int.chello.at>;
	Sat, 29 Jul 2006 08:14:29 +0200
Received: from wombat.fafoe.narf.at ([213.47.85.26]) by viefep31-int.chello.at
	(InterMail vG.2.02.00.00 201-2161-120-101-20051020) with ESMTP id
	<20060729061429.WQYF14536.viefep31-int.chello.at@wombat.fafoe.narf.at>;
	Sat, 29 Jul 2006 08:14:29 +0200
Received: by wombat.fafoe.narf.at (Postfix, from userid 1001)
	id 49DE2BC75; Sat, 29 Jul 2006 08:14:27 +0200 (CEST)
Date: Sat, 29 Jul 2006 08:14:27 +0200
From: Stefan Farfeleder <stefanf@FreeBSD.org>
To: "Simon L. Nielsen" <simon@FreeBSD.org>
Message-ID: <20060729061426.GA79029@wombat.fafoe.narf.at>
References: <200607282300.k6SN0Gdn005489@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200607282300.k6SN0Gdn005489@repoman.freebsd.org>
User-Agent: Mutt/1.5.12-2006-07-14
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libmp mpasbn.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Jul 2006 06:14:33 -0000

On Fri, Jul 28, 2006 at 11:00:16PM +0000, Simon L. Nielsen wrote:
> simon       2006-07-28 23:00:16 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     lib/libmp            mpasbn.c 
>   Log:
>   Do not put BN_CTX structures on the stack, but instead allocate them
>   runtime using BN_CTX_new().  This is done since in OpenSSL 0.9.7e we
>   can only allocate BN_CTX on the stack by including an internal OpenSSL
>   header file, and in OpenSSL 0.9.8 BN_CTX is entirely opaque, so having
>   it on the stack is not possible at all.
>   
>   This is done as preparation for OpenSSL 0.9.8b import.

It might be preferable to pass the allocated BN_CTXs to _mdiv(),
_mult() and _sdiv() because then msqrt() would have to call
BN_CTX_new() only once.

Stefan