From owner-svn-src-all@FreeBSD.ORG Tue Mar 13 07:20:01 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 91B4C1065679; Tue, 13 Mar 2012 07:20:01 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by mx1.freebsd.org (Postfix) with ESMTP id A1BAE8FC0A; Tue, 13 Mar 2012 07:20:00 +0000 (UTC) Received: by wibhq7 with SMTP id hq7so228198wib.13 for ; Tue, 13 Mar 2012 00:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=cmvRTOaEPPm3CRqZEh9fHgDejXZFzN44mOOZDVIonRM=; b=F4T6PMRfo/+T95GtwJxPa8kXo1sdQOZB12yK7ZlgJiGEfgp3wy/TlTTwolVRbfi/jk YKE4c8JrlFqlzfaVawaLJcdaIvz9iRznVDjOpn7TEKMcJAqxQnHuEIl8Vr6CtucWjmuF N570fn4MNlSqa/ilts3lDxYcOYYgvnryp/C1HA9whXnKbJBaHWZxhwyN5Klo3R30Khgb 5zrDeB/vzytTZ2j2J8aB7UM2miajCDHiRDmOcJjDuxGlH0UdcKzUwyV2+IHodfegwrfm b7/mtNK9/dFvyxRznMw1z7b3P1DbIPLMq4pu013K6wWvEjbu1YTHG71haGCOEJRiv5Us erdg== Received: by 10.180.83.42 with SMTP id n10mr4674709wiy.9.1331623199705; Tue, 13 Mar 2012 00:19:59 -0700 (PDT) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua. [212.86.226.226]) by mx.google.com with ESMTPS id bg3sm40784580wib.10.2012.03.13.00.19.57 (version=SSLv3 cipher=OTHER); Tue, 13 Mar 2012 00:19:58 -0700 (PDT) Sender: Alexander Motin Message-ID: <4F5EF51C.6080806@FreeBSD.org> Date: Tue, 13 Mar 2012 09:19:56 +0200 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:10.0.2) Gecko/20120226 Thunderbird/10.0.2 MIME-Version: 1.0 To: Josh Paetzel References: <201203122141.q2CLfUu2088344@svn.freebsd.org> In-Reply-To: <201203122141.q2CLfUu2088344@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Kris Moore Subject: Re: svn commit: r232901 - head/usr.sbin/pc-sysinstall/backend X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2012 07:20:01 -0000 On 03/12/12 23:41, Josh Paetzel wrote: > Author: jpaetzel > Date: Mon Mar 12 21:41:29 2012 > New Revision: 232901 > URL: http://svn.freebsd.org/changeset/base/232901 > > Log: > Use gpart "-a" flag to 4k alignment. > > Submitted by: kris > Obtained from: PC-BSD > > Modified: > head/usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh > head/usr.sbin/pc-sysinstall/backend/functions-disk.sh > > Modified: head/usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh > ============================================================================== > --- head/usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh Mon Mar 12 21:34:10 2012 (r232900) > +++ head/usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh Mon Mar 12 21:41:29 2012 (r232901) > @@ -314,7 +314,7 @@ setup_gpart_partitions() > if [ "$CURPART" = "2" ] ; then > # If this is GPT, make sure first partition is aligned to 4k > sleep 2 > - rc_halt "gpart add -b 2016 ${SOUT} -t ${PARTYPE} ${_pDisk}" > + rc_halt "gpart add -a 4k ${SOUT} -t ${PARTYPE} ${_pDisk}" > else > sleep 2 > rc_halt "gpart add ${SOUT} -t ${PARTYPE} ${_pDisk}" Just to note: if neither -b, nor -a is specified, gpart should now use stripe size/offset values provided by GEOM. So, for example, if partition is created on top of GEOM_STRIPE with 64K strip size, gpart would automatically align to that value. Forcing 4K alignment is a safety measure in case if device with 4K sectors wasn't detected as such, but it can be a pessimization for devices with stripes bigger then 4K. -- Alexander Motin