From owner-svn-src-all@FreeBSD.ORG Thu Jun 3 18:34:35 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 231C9106566C; Thu, 3 Jun 2010 18:34:35 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from svn.freebsd.org (unknown [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 121688FC12; Thu, 3 Jun 2010 18:34:35 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o53IYYAC059221; Thu, 3 Jun 2010 18:34:34 GMT (envelope-from kib@svn.freebsd.org) Received: (from kib@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o53IYYEB059219; Thu, 3 Jun 2010 18:34:34 GMT (envelope-from kib@svn.freebsd.org) Message-Id: <201006031834.o53IYYEB059219@svn.freebsd.org> From: Konstantin Belousov Date: Thu, 3 Jun 2010 18:34:34 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r208791 - head/sys/vm X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jun 2010 18:34:35 -0000 Author: kib Date: Thu Jun 3 18:34:34 2010 New Revision: 208791 URL: http://svn.freebsd.org/changeset/base/208791 Log: Do not leak vm page lock in vm_contig_launder(), vm_pageout_page_lock() always returns with the page locked. Submitted by: alc Pointy hat to: kib Modified: head/sys/vm/vm_contig.c Modified: head/sys/vm/vm_contig.c ============================================================================== --- head/sys/vm/vm_contig.c Thu Jun 3 17:55:42 2010 (r208790) +++ head/sys/vm/vm_contig.c Thu Jun 3 18:34:34 2010 (r208791) @@ -168,8 +168,10 @@ vm_contig_launder(int queue) if ((m->flags & PG_MARKER) != 0) continue; - if (!vm_pageout_page_lock(m, &next)) + if (!vm_pageout_page_lock(m, &next)) { + vm_page_unlock(m); continue; + } KASSERT(VM_PAGE_INQUEUE2(m, queue), ("vm_contig_launder: page %p's queue is not %d", m, queue)); error = vm_contig_launder_page(m, &next);