From owner-freebsd-bugs@FreeBSD.ORG Fri Nov 14 07:30:22 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 71E4616A4CE for ; Fri, 14 Nov 2003 07:30:22 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id AE1EF43FD7 for ; Fri, 14 Nov 2003 07:30:20 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id hAEFUKFY048807 for ; Fri, 14 Nov 2003 07:30:20 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id hAEFUKDg048806; Fri, 14 Nov 2003 07:30:20 -0800 (PST) (envelope-from gnats) Resent-Date: Fri, 14 Nov 2003 07:30:20 -0800 (PST) Resent-Message-Id: <200311141530.hAEFUKDg048806@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Langille Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7DDA116A4CE for ; Fri, 14 Nov 2003 07:21:08 -0800 (PST) Received: from xeon.unixathome.org (bast.unixathome.org [66.11.174.150]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE2CF43FEC for ; Fri, 14 Nov 2003 07:21:05 -0800 (PST) (envelope-from dan@xeon.unixathome.org) Received: by xeon.unixathome.org (Postfix, from userid 1000) id 307F73E50; Fri, 14 Nov 2003 10:21:05 -0500 (EST) Message-Id: <20031114152105.307F73E50@xeon.unixathome.org> Date: Fri, 14 Nov 2003 10:21:05 -0500 (EST) From: Dan Langille To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/59291: [PATCH] pthread patch committed earlier is incomplete X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Dan Langille List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Nov 2003 15:30:22 -0000 >Number: 59291 >Category: kern >Synopsis: [PATCH] pthread patch committed earlier is incomplete >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Nov 14 07:30:19 PST 2003 >Closed-Date: >Last-Modified: >Originator: Dan Langille >Release: FreeBSD 4.8-STABLE i386 >Organization: The FreeBSD Diary >Environment: System: FreeBSD xeon.unixathome.org 4.8-STABLE FreeBSD 4.8-STABLE #0: Fri Aug 15 16:11:30 EDT 2003 dan@polo.unixathome.org:/usr/obj/usr/src/sys/XEON i386 >Description: The patch committed on Sat Oct 11 18:37:09 2003 UTC was incomplete. I blame myself because the original patch was reversed and contained debugging code. See also: original patch: http://docs.freebsd.org/cgi/getmsg.cgi?fetch=440371+0+/usr/local/www/db/text/2003/freebsd-hackers/20030921.freebsd-hackers original PR: http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/56274 >How-To-Repeat: Apply the committed patch: http://www.freebsd.org/cgi/cvsweb.cgi/src/lib/libc_r/uthread/uthread_write.c.diff?r1=1.16.2.6&r2=1.16.2.7 Run the tests described in original PR Run the btape test supplied with Bacula >Fix: Apply this patch, which adds in the missing lines. --- uthread_write.c.patch begins here --- --- /home/dan/uthread_write.c Fri Nov 14 09:47:55 2003 +++ uthread_write.c Mon Sep 29 06:05:35 2003 @@ -137,6 +137,10 @@ else ret = n; + if (n == 0) { + break; + } + /* Check if the write has completed: */ } else if (num >= nbytes) /* Return the number of bytes written: */ --- uthread_write.c.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: