From owner-svn-src-head@freebsd.org Wed May 30 08:02:13 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CDE25F76172; Wed, 30 May 2018 08:02:13 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from mail-qt0-x244.google.com (mail-qt0-x244.google.com [IPv6:2607:f8b0:400d:c0d::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6365A75ADE; Wed, 30 May 2018 08:02:13 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: by mail-qt0-x244.google.com with SMTP id h5-v6so14107357qtm.13; Wed, 30 May 2018 01:02:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=LtObeZd/6ippPpKOO/sRj4arWUmHcqS1T5XyCE1zbEc=; b=YOldjOmR9hx5mGcbj/PRbsNExdohcMBnNvgQyqg4p9UNqvwNk24bVEf/J4MxvT8rc0 AxanXzkGi3TLChV/JhkA71k+q+sjjrYOZaEAq0othI0D2H2ncIO1eVbhG/V/N1SrLGnR 6zH92lqmDW8bKvM7J9rJh7f89x6ZTpZjYiwTG8TlbQlSBFO4h4KzPf/h+G6M2rWotWYO 5Er8Lc98ERLgJponUEb6lvhtRYaWI4XYIcu5Ge3w2JQ/yI0fYDIN/w8vjit+CFSVr8ay FUXbsnzu4Gy/mfbtb/cA9/O0vO/s7FE9W1srto1rRbx/ElZD5aM/O9kef5rnKWpdJfNa 6SNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=LtObeZd/6ippPpKOO/sRj4arWUmHcqS1T5XyCE1zbEc=; b=RkA3MQODJkl1kSEgOVtuJcbgRwM7ezlHKk+QVYAqVR5QapbRWFAuktzKFOjDYRN+6V PqDGCZOe0v/QTUNHVzOTLOdM1zwwqKrdP55j8w+lfhrJJ9BUSqDs69jVu91UTbmbvCRC WKMQ4Z4lYxGT5bRnO2BTS8IvXtQt6+eRVg7glSiwBRvZ3fZ9+31HxwEWUEIRi2kHeNCp tSMUyrr29HMDtG/E6ky0DRT4IpnfqM/UQEECuD6aK9KUkAarAhKqkofXHAlhsVndyLER flVWVoaWkC94Ssw1kWbaH383KkrfFsK7jBD9TlaqD8U4NtGBLAMdXmYI4s4wM5Rgtu4t nk9g== X-Gm-Message-State: APt69E3nTDQgiqwPRCQL2MWBJC49vJrq3t86tMFQk9tno6jzpO25BkMm t+hh6d9BaETimquMSW0q8O9eupyKhfarPoxCPEc= X-Google-Smtp-Source: ADUXVKI7GkXR6GsyXUNxPOtJH4YHj+W80fS+fVrYUSEZYY3T88hEOVu8sqsL+ve2/K5b4JI1ZMkIN0pRQpsloYhAF1E= X-Received: by 2002:ac8:1b7b:: with SMTP id p56-v6mr1517694qtk.254.1527667332922; Wed, 30 May 2018 01:02:12 -0700 (PDT) MIME-Version: 1.0 Sender: antoine.brodin.freebsd@gmail.com Received: by 2002:a0c:accf:0:0:0:0:0 with HTTP; Wed, 30 May 2018 01:02:12 -0700 (PDT) In-Reply-To: <1cbed89b-e485-7f15-d3ab-f018024203eb@selasky.org> References: <201805280812.w4S8CI56046943@repo.freebsd.org> <383666b1-06a9-ac96-812f-c602c8e5e5af@selasky.org> <21342cd6-bf7e-263f-f077-2e073fe9ebef@selasky.org> <1cbed89b-e485-7f15-d3ab-f018024203eb@selasky.org> From: Antoine Brodin Date: Wed, 30 May 2018 08:02:12 +0000 X-Google-Sender-Auth: S6qtF5osJgkeK3GQAlkCJV43p4U Message-ID: Subject: Re: svn commit: r334277 - in head: contrib/libpcap contrib/ofed/usr.lib/3 contrib/pf/pflogd contrib/wpa/src/l2_packet lib lib/libpcap share/mk usr.sbin/cxgbetool To: Hans Petter Selasky Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 08:02:14 -0000 On Wed, May 30, 2018 at 7:52 AM, Hans Petter Selasky wrote: > On 05/30/18 09:36, Antoine Brodin wrote: >> >> On Wed, May 30, 2018 at 7:31 AM, Hans Petter Selasky >> wrote: >>> >>> On 05/30/18 09:04, Hans Petter Selasky wrote: >>>> >>>> >>>> On 05/30/18 08:04, Antoine Brodin wrote: >>>>> >>>>> >>>>> On Mon, May 28, 2018 at 10:12 AM, Hans Petter Selasky >>>>> wrote: >>>>>> >>>>>> >>>>>> Author: hselasky >>>>>> Date: Mon May 28 08:12:18 2018 >>>>>> New Revision: 334277 >>>>>> URL: https://svnweb.freebsd.org/changeset/base/334277 >>>>>> >>>>>> Log: >>>>>> MFV r333789: libpcap 1.9.0 (pre-release) >>>>>> >>>>>> MFC after: 1 month >>>>>> Sponsored by: Mellanox Technologies >>>>> >>>>> >>>>> >>>>> Hi, >>>>> >>>>> Some things seem to be missing. >>>>> For instance, pcap_setsampling and pcap_open are now declared in >>>>> pcap.h but they are not compiled in libpcap.so. >>>>> net/p5-Net-Pcap is confused by this: >>>>> >>>>> >>>>> http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p471115_s334360/logs/errors/p5-Net-Pcap-0.18.log >>>> >>>> >>>> >>> >>> Hi, >>> >>> net/p5-Net-Pcap is supposed to depend on and use net/libpcap which >>> install >>> into /usr/local/lib and /usr/local/include from what I understand. >> >> >> No, it worked fine with libpcap from base previously. >> pcap/pcap.h now exposes functions from pcap-new.c but pcap-new.c is >> not compiled. > > > Hi, > > pcap-new.c is only compiled if libpcap should have remote support, which the > in-base library didn't have? > > Can you try to modify the net/p5-Net-Pcap Makefile like this: > > BUILD_DEPENDS= p5-IO-Interface>=0:net/p5-IO-Interface \ > libpcap>=0:net/libpcap > > CFLAGS+= -I${PREFIX}/include > LDFLAGS+= -L${PREFIX}/lib Could the pcap/pcap.h header be fixed instead with #ifdef HAVE_REMOTE as it previously had? Antoine