From owner-p4-projects@FreeBSD.ORG  Fri Feb 15 00:46:43 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 7B89416A46D; Fri, 15 Feb 2008 00:46:43 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3DFBE16A419;
	Fri, 15 Feb 2008 00:46:43 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Received: from weak.local (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 6B4C113C4CE;
	Fri, 15 Feb 2008 00:46:42 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Message-ID: <47B4E0F1.6060006@FreeBSD.org>
Date: Fri, 15 Feb 2008 01:46:41 +0100
From: Kris Kennaway <kris@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031)
MIME-Version: 1.0
To: John Baldwin <jhb@freebsd.org>
References: <200802080420.m184Kvmf077416@repoman.freebsd.org>
	<200802141032.33861.jhb@freebsd.org>
In-Reply-To: <200802141032.33861.jhb@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Perforce Change Reviews <perforce@freebsd.org>,
	Kip Macy <kmacy@freebsd.org>
Subject: Re: PERFORCE change 135010 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Feb 2008 00:46:43 -0000

John Baldwin wrote:
> On Thursday 07 February 2008 11:20:57 pm Kip Macy wrote:
>> http://perforce.freebsd.org/chv.cgi?CH=135010
>>
>> Change 135010 by kmacy@kmacy:storage:toehead on 2008/02/08 04:20:17
>>
>> 	add opt_global.h to dependencies
>>
>> Affected files ...
>>
>> .. //depot/projects/toehead/sys/modules/cxgb/tom/Makefile#3 edit
>>
>> Differences ...
>>
>> ==== //depot/projects/toehead/sys/modules/cxgb/tom/Makefile#3 (text+ko) ====
>>
>> @@ -5,7 +5,8 @@
>>  KMOD=	tom
>>  SRCS=   cxgb_tom.c cxgb_cpl_io.c cxgb_listen.c cxgb_tom_sysctl.c cxgb_cpl_socket.c
>>  SRCS+=  cxgb_ddp.c cxgb_vm.c
>> -SRCS+=	opt_compat.h opt_inet.h opt_inet6.h opt_ipsec.h opt_mac.h opt_tcpdebug.h opt_ddb.h
>> +SRCS+=	opt_compat.h opt_inet.h opt_inet6.h opt_ipsec.h opt_mac.h
>> +SRCS+=  opt_tcpdebug.h opt_ddb.h opt_global.h
>>  SRCS+=	device_if.h bus_if.h pci_if.h
>>  
>>  #CFLAGS+= -DDEBUG_PRINT -DDEBUG
>>
> 
> That's kind of odd.  Do you have an explicit #include "opt_global.h" somewhere?
> 

It also doesn't work :)

The problem is that if you build a kernel+module with 
INVARIANTS+INVARIANT_SUPPORT set, then remove both options, rerun 
config, make depend, make all, the module is not rebuilt and fails to load.

Kris