From owner-freebsd-bugs@FreeBSD.ORG  Mon Jun  5 14:10:40 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DE98616B41D
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  5 Jun 2006 14:10:40 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 92B6C43D79
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  5 Jun 2006 14:10:27 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k55EALZk028539
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 5 Jun 2006 14:10:21 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k55EALJZ028538;
	Mon, 5 Jun 2006 14:10:21 GMT (envelope-from gnats)
Resent-Date: Mon, 5 Jun 2006 14:10:21 GMT
Resent-Message-Id: <200606051410.k55EALJZ028538@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Michael Heyman <Michael.Heyman@sparta.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D144316B164
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon,  5 Jun 2006 14:07:39 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0156A43D72
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon,  5 Jun 2006 14:07:33 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k55E7Q8C061560
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 5 Jun 2006 14:07:26 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k55E7Qlk061559;
	Mon, 5 Jun 2006 14:07:26 GMT (envelope-from nobody)
Message-Id: <200606051407.k55E7Qlk061559@www.freebsd.org>
Date: Mon, 5 Jun 2006 14:07:26 GMT
From: Michael Heyman <Michael.Heyman@sparta.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Cc: 
Subject: kern/98529: [netgraph] False "ng_generic_msg: number of nodes
	changed" report
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Jun 2006 14:10:51 -0000


>Number:         98529
>Category:       kern
>Synopsis:       [netgraph] False "ng_generic_msg: number of nodes changed" report
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 05 14:10:20 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Michael Heyman
>Release:        FreeBSD 7-CURRENT
>Organization:
>Environment:
>Description:
In ng_base.c around line 2658 there can be a false error report saying "ng_generic_msg: number of nodes changed". This report occurs when the response message fills up.

The false report occurs when the response message is full and would not receive any more information even though there are still nodes in ng_nodelist to scan.

>How-To-Repeat:

>Fix:
Moving the check down 4 lines to below the "if(NG_NODE_NOT_VALID(node))" and "if(!unamed && (!NG_NODE_HAS_NAME(node)))" conditionals will remove the false error report.


>Release-Note:
>Audit-Trail:
>Unformatted: