From owner-svn-src-all@FreeBSD.ORG  Wed Jun 20 09:19:15 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E93BF106566C;
	Wed, 20 Jun 2012 09:19:15 +0000 (UTC) (envelope-from gprspb@mail.ru)
Received: from fallback4.mail.ru (fallback4.mail.ru [94.100.176.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 8A0EA8FC12;
	Wed, 20 Jun 2012 09:19:15 +0000 (UTC)
Received: from smtp23.mail.ru (smtp23.mail.ru [94.100.176.176])
	by fallback4.mail.ru (mPOP.Fallback_MX) with ESMTP id DB2768B3C44B;
	Wed, 20 Jun 2012 13:19:13 +0400 (MSK)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru;
	s=mail; 
	h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date;
	bh=IT88HzSX9N5abpczEMZTXZ7hc6KCFjATl5zRNSBDzGg=; 
	b=rOfceUKruvrai9f4OzX9koZg5ORzRk+/pV+3gKqlAcBlX+A+5A3BgEE7L1COuyuaE1yM6Pp1Ad06A0KcXReFY3r0TbxkqFIbCcd5xFUqSkOS8MXLbOLPS6H6g2ATjwQF;
Received: from [93.185.182.46] (port=20381 helo=gpr.nnz-home.ru)
	by smtp23.mail.ru with esmtpa (envelope-from <gprspb@mail.ru>)
	id 1ShH40-0000uC-H6; Wed, 20 Jun 2012 13:19:00 +0400
Received: from gpr by gpr.nnz-home.ru with local (Exim 4.77 (FreeBSD))
	(envelope-from <gprspb@mail.ru>)
	id 1ShH3j-000BrY-8T; Wed, 20 Jun 2012 13:18:43 +0400
Date: Wed, 20 Jun 2012 13:18:43 +0400
From: Gennady Proskurin <gprspb@mail.ru>
To: Daniel O'Connor <doconnor@gsoft.com.au>
Message-ID: <20120620091843.GB832@gpr.nnz-home.ru>
References: <68FBE843-7337-4C90-B01F-E0CAABB62BCD@gsoft.com.au>
	<31750.1340083631@critter.freebsd.dk>
	<20120620074101.GA832@gpr.nnz-home.ru>
	<A1A78677-4957-4690-A8F2-609F2207C92A@gsoft.com.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <A1A78677-4957-4690-A8F2-609F2207C92A@gsoft.com.au>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Spam: Not detected
X-Mras: Ok
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	Gennady Proskurin <gprspb@mail.ru>, src-committers@freebsd.org,
	Poul-Henning Kamp <phk@phk.freebsd.dk>
Subject: Re: svn commit: r237223 - head/sys/dev/fb
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jun 2012 09:19:16 -0000

On Wed, Jun 20, 2012 at 05:59:07PM +0930, Daniel O'Connor wrote:
> 
> On 20/06/2012, at 17:11, Gennady Proskurin wrote:
> > On Tue, Jun 19, 2012 at 05:27:11AM +0000, Poul-Henning Kamp wrote:
> >> In message <68FBE843-7337-4C90-B01F-E0CAABB62BCD@gsoft.com.au>, "Daniel O'Conno
> >> r" writes:
> >> 
> >>>> If size is odd, this does not copy the last byte. Not sure, whether =
> >>> this is intended.
> >> 
> >> Feel free to improve...
> > 
> > <fb.patch>
> 
> 
> Surely if you pass it an odd size you made a mistake - either the wrong function was used or you computed the size incorrectly.

Functions are called "bcopy_io" and so, such names tell nothing about data size
they work with ("copyw" tells something). If it is not supposed to work with
odd size, I agree, my patch is overkill, something like KASSERT (or just
one-line comment) is better.

I just wanted to be sure, that potential bug in this code is known to
developpers.