From owner-cvs-all@FreeBSD.ORG  Wed Nov 16 17:49:42 2011
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id AB7A01065670; Wed, 16 Nov 2011 17:49:42 +0000 (UTC)
Date: Wed, 16 Nov 2011 17:49:42 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Jan Beich <jbeich@tormail.net>
Message-ID: <20111116174942.GA81352@FreeBSD.org>
References: <201111161607.pAGG7trI042076__6520.72345042161$1321459728$gmane$org@repoman.freebsd.org>
	<1RQicz-000NXY-MJ@internal.tormail.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <1RQicz-000NXY-MJ@internal.tormail.net>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/lang/s9fes Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Nov 2011 17:49:42 -0000

On Wed, Nov 16, 2011 at 09:43:07AM -0700, Jan Beich wrote:
> Alexey Dokuchaev <danfe@FreeBSD.org> writes:
> >
> >   Modified files:
> >     lang/s9fes           Makefile 
> >   Log:
> >   Instead of marking this port as make jobs (-jX) unsafe, apply a trivial
> >   fix and also properly respect CC, CFLAGS, PREFIX, and LIBDIR.
> 
> TIMTOWTDI, one can just pass everything from MAKE_ENV
> 
>   MAKE_ARGS= ${MAKE_ENV}
>   LIBDIR=    ${DATADIR}
> 
> It has slight advantage of proper quoting, e.g. when ${CC} contains
> distcc/ccache + compiler separated by space.

Thanks for suggestion, I will evaluate it tomorrow and quite probably commit.

All I can say right now is that I'm not sure that passing full-blown
MAKE_ENV as MAKE_ARGS is necessary, since obvious CC quoting issues can be
trivially fixed by, hm, quoting it in place.

./danfe