From owner-svn-src-head@FreeBSD.ORG Thu Sep 18 05:18:37 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 49E2DE05; Thu, 18 Sep 2014 05:18:37 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id C0CDBB9A; Thu, 18 Sep 2014 05:18:36 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id s8I5IYvL093430 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 18 Sep 2014 09:18:34 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id s8I5IYH8093429; Thu, 18 Sep 2014 09:18:34 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Thu, 18 Sep 2014 09:18:34 +0400 From: Gleb Smirnoff To: Marcelo Araujo , kevlo@FreeBSD.org Subject: Re: svn commit: r271735 - head/sys/net Message-ID: <20140918051834.GD89442@FreeBSD.org> References: <201409180309.s8I39Zmh045601@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201409180309.s8I39Zmh045601@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Sep 2014 05:18:37 -0000 On Thu, Sep 18, 2014 at 03:09:35AM +0000, Marcelo Araujo wrote: M> Author: araujo (ports committer) M> Date: Thu Sep 18 03:09:34 2014 M> New Revision: 271735 M> URL: http://svnweb.freebsd.org/changeset/base/271735 M> M> Log: M> Remove old comment, we already do 802.1q tagging. But the comment speaks about 802.1p priority tagging, which we do not support. So the comment was absolutely correct. I'd prefer to see patch reverted. M> Phabric: D797 M> Reviewed by: kevlo M> Approved by: kevlo M> Sponsored by: QNAP Systems Inc. M> M> Modified: M> head/sys/net/if_vlan.c M> M> Modified: head/sys/net/if_vlan.c M> ============================================================================== M> --- head/sys/net/if_vlan.c Thu Sep 18 03:02:00 2014 (r271734) M> +++ head/sys/net/if_vlan.c Thu Sep 18 03:09:34 2014 (r271735) M> @@ -29,8 +29,7 @@ M> M> /* M> * if_vlan.c - pseudo-device driver for IEEE 802.1Q virtual LANs. M> - * Might be extended some day to also handle IEEE 802.1p priority M> - * tagging. This is sort of sneaky in the implementation, since M> + * This is sort of sneaky in the implementation, since M> * we need to pretend to be enough of an Ethernet implementation M> * to make arp work. The way we do this is by telling everyone M> * that we are an Ethernet, and then catch the packets that M> -- Totus tuus, Glebius.