From owner-cvs-all@FreeBSD.ORG  Fri Apr  8 02:24:59 2011
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 89FF21065672; Fri,  8 Apr 2011 02:24:59 +0000 (UTC)
Date: Fri, 8 Apr 2011 02:24:59 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: bf1783@gmail.com
Message-ID: <20110408022459.GA40411@FreeBSD.org>
References: <201104072239.p37Md9oh031253@repoman.freebsd.org>
	<BANLkTikmUZsHNjw2Jpe8Y7v5CD6WkZGtoQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <BANLkTikmUZsHNjw2Jpe8Y7v5CD6WkZGtoQ@mail.gmail.com>
User-Agent: Mutt/1.4.2.1i
Cc: Rene Ladan <rene@freebsd.org>, cvs-ports@freebsd.org, cvs-all@freebsd.org,
	ports-committers@freebsd.org
Subject: Re: cvs commit: ports/www/chromium Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Apr 2011 02:24:59 -0000

On Fri, Apr 08, 2011 at 12:53:27AM +0000, b. f. wrote:
> On 4/7/11, Rene Ladan <rene@freebsd.org> wrote:
> > rene        2011-04-07 22:39:09 UTC
> >
> >   FreeBSD ports repository
> >
> >   Modified files:
> >     www/chromium         Makefile
> >   Log:
> >   Cleanup Makefile a bit more:
> >   - Convert two explicit dependencies to a USE_GNOME and USE_XORG component
> >   - Use buildtime SSE2 detection instead of an OPTION
> 
> How is this last change above going to work for building i386
> packages, if the package-building machine has SSE2, but other machines
> that use the packages do not? (Or vice versa, for that matter.)  You
> may add some sanity checks, and make the effect of the option
> i386-specific, but I don't think that you can safely remove this
> option entirely --  and the default setting has to allow packages to
> work on all i386.

I've been thinking about this as well.  However, instead of bringing back
this OPTION, I'd suggest addind "|| defined(PACKAGE_BUILDING)" to that
.if to ensure that packages are can be safely run on pre-SSE2 CPUs.

./danfe