From owner-svn-src-all@FreeBSD.ORG Tue Apr 19 07:36:53 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 881DB1065670; Tue, 19 Apr 2011 07:36:53 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 5CEC28FC08; Tue, 19 Apr 2011 07:36:53 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id p3J7arGa098477; Tue, 19 Apr 2011 07:36:53 GMT (envelope-from ru@svn.freebsd.org) Received: (from ru@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id p3J7arv5098475; Tue, 19 Apr 2011 07:36:53 GMT (envelope-from ru@svn.freebsd.org) Message-Id: <201104190736.p3J7arv5098475@svn.freebsd.org> From: Ruslan Ermilov Date: Tue, 19 Apr 2011 07:36:53 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r220815 - stable/8/sys/nfsclient X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 07:36:53 -0000 Author: ru Date: Tue Apr 19 07:36:53 2011 New Revision: 220815 URL: http://svn.freebsd.org/changeset/base/220815 Log: MFC r220595: - Fixed nfs_printf() to use vprintf(). - Fixed vfs.nfs.acdebug sysctl's description. - Fixed panic when compiled with NFS_ACDEBUG. Modified: stable/8/sys/nfsclient/nfs_subs.c Directory Properties: stable/8/sys/ (props changed) Modified: stable/8/sys/nfsclient/nfs_subs.c ============================================================================== --- stable/8/sys/nfsclient/nfs_subs.c Tue Apr 19 07:30:22 2011 (r220814) +++ stable/8/sys/nfsclient/nfs_subs.c Tue Apr 19 07:36:53 2011 (r220815) @@ -442,7 +442,7 @@ nfs_printf(const char *fmt, ...) mtx_lock(&Giant); va_start(ap, fmt); - printf(fmt, ap); + vprintf(fmt, ap); va_end(ap); mtx_unlock(&Giant); } @@ -656,7 +656,7 @@ out: SYSCTL_DECL(_vfs_nfs); static int nfs_acdebug; SYSCTL_INT(_vfs_nfs, OID_AUTO, acdebug, CTLFLAG_RW, &nfs_acdebug, 0, - "Toggle acdebug (access cache debug) flag"); + "Toggle acdebug (attribute cache debug) flag"); #endif /* @@ -713,6 +713,9 @@ nfs_getattrcache(struct vnode *vp, struc if ((time_second - np->n_attrstamp) >= timeo) { nfsstats.attrcache_misses++; mtx_unlock(&np->n_mtx); +#ifdef NFS_ACDEBUG + mtx_unlock(&Giant); /* nfs_printf() */ +#endif KDTRACE_NFS_ATTRCACHE_GET_MISS(vp); return (ENOENT); }