From nobody Sat Jul 31 00:16:00 2021
X-Original-To: python@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 104DD11D6AF7
for <python@mlmmj.nyi.freebsd.org>; Sat, 31 Jul 2021 00:16:01 +0000 (UTC)
(envelope-from bugzilla-noreply@freebsd.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
client-signature RSA-PSS (4096 bits) client-digest SHA256)
(Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 4Gc4YX6rv8z4TKh
for <python@FreeBSD.org>; Sat, 31 Jul 2021 00:16:00 +0000 (UTC)
(envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
(Client did not present a certificate)
by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D25016C89
for <python@FreeBSD.org>; Sat, 31 Jul 2021 00:16:00 +0000 (UTC)
(envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org ([127.0.1.5])
by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 16V0G0v3093878
for <python@FreeBSD.org>; Sat, 31 Jul 2021 00:16:00 GMT
(envelope-from bugzilla-noreply@freebsd.org)
Received: (from www@localhost)
by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 16V0G07l093877
for python@FreeBSD.org; Sat, 31 Jul 2021 00:16:00 GMT
(envelope-from bugzilla-noreply@freebsd.org)
X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f
From: bugzilla-noreply@freebsd.org
To: python@FreeBSD.org
Subject: [Bug 256187] [NEW-PORT] www/py-django-ckeditor: Django admin
CKEditor integration
Date: Sat, 31 Jul 2021 00:16:00 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: feature, needs-patch, needs-qa
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: koobs@FreeBSD.org
X-Bugzilla-Status: Open
X-Bugzilla-Resolution:
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org
X-Bugzilla-Flags: maintainer-feedback?
X-Bugzilla-Changed-Fields: flagtypes.name short_desc keywords cc bug_severity
Message-ID: <bug-256187-21822-h0nE2khwmS@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-256187-21822@https.bugs.freebsd.org/bugzilla/>
References: <bug-256187-21822@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
List-Id: FreeBSD-specific Python issues <freebsd-python.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/freebsd-python
List-Help: <mailto:python+help@freebsd.org>
List-Post: <mailto:python@freebsd.org>
List-Subscribe: <mailto:python+subscribe@freebsd.org>
List-Unsubscribe: <mailto:python+unsubscribe@freebsd.org>
Sender: owner-freebsd-python@freebsd.org
X-BeenThere: freebsd-python@freebsd.org
MIME-Version: 1.0
X-ThisMailContainsUnwantedMimeParts: N
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256187
Kubilay Kocak <koobs@FreeBSD.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |maintainer-feedback?(gettok
| |nowmi@yahoo.com)
Summary|[NEW-PORT] |[NEW-PORT]
|www/py-django-ckeditor: |www/py-django-ckeditor:
|Django ckeditor version 6 |Django admin CKEditor
| |integration
Keywords| |needs-patch
CC| |gettoknowmi@yahoo.com
Severity|Affects Some People |Affects Only Me
--- Comment #3 from Kubilay Kocak <koobs@FreeBSD.org> ---
Review items:
- Latest upstream version is 6.1.0
- Add python to CATEGORIES
- Match COMMENT to upstream description (setup.py:description). "Django ad=
min
CKEditor integration"
- Match upstream dependency <versions-specs> ("django-js-asset>=3D1.2.2",)
- ",run" is incorrect for most python package cases. It excludes "build" (=
'run
time *only*), which is required to compile py files to pyo pyc counterparts=
.=20
- Upstream is only testing Python 3.6+, this port declares 3.4+ support. T=
his
isd fine if the packages tests pass with all allowed versions.
- Upstream ships tests. Add TEST_DEPENDS and a test-target for comprehensi=
ve
QA:
Note #1: we don't need to run tox, coverage or lint tests, the following two
should be sufficient:
TEST_ENV+=3DDJANGO_SETTINGS_MODULE=3Dckeditor_demo.settings
${SETENV} ${TEST_ENV} ${PYTHON_CMD} manage.py test ckeditor_demo=20
${SETENV} ${TEST_ENV} ${PYTHON_CMD} manage.py validate_templates
Note 2: There are a few more dependencies for tests (pillow,
django_extensions). Only add compulsory ones. Interesting to note that these
deps arent in install_requires. Are they 'optional' ? Maybe its worth having
OPTIONS for these.
Confirmation that the port passes tests (portlint, poudriere) would also be
great.
--=20
You are receiving this mail because:
You are on the CC list for the bug.=