From owner-svn-src-head@freebsd.org Sun May 19 17:51:16 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 223E715B3EB8; Sun, 19 May 2019 17:51:16 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DE78E6E0F2; Sun, 19 May 2019 17:51:14 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x4JHp6rt029300 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 19 May 2019 20:51:09 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x4JHp6rt029300 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x4JHp4F7029299; Sun, 19 May 2019 20:51:04 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 19 May 2019 20:51:04 +0300 From: Konstantin Belousov To: Yoshihiro Ota Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r347968 - head/sys/kern Message-ID: <20190519175104.GP2748@kib.kiev.ua> References: <201905190918.x4J9IAs1036579@repo.freebsd.org> <20190519115228.49fdc5c833c2abe06f894dc2@j.email.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190519115228.49fdc5c833c2abe06f894dc2@j.email.ne.jp> User-Agent: Mutt/1.11.4 (2019-03-13) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 May 2019 17:51:16 -0000 On Sun, May 19, 2019 at 11:52:28AM -0400, Yoshihiro Ota wrote: > Hi, > > Does this change fix 'mount -u -rw /path' to remount read-only device with write mode? > I moticed an issue a couple of days ago but didn't have time to conform nor report. I do not understand your description. If you mean does this commit has any relevance to the issue of remounting ro->rw, it should not. It only affects rw->ro remounts, when you have a binary executed from the mount point. > > Thanks, > Hiro > > On Sun, 19 May 2019 09:18:10 +0000 (UTC) > Konstantin Belousov wrote: > > > Author: kib > > Date: Sun May 19 09:18:09 2019 > > New Revision: 347968 > > URL: https://svnweb.freebsd.org/changeset/base/347968 > > > > Log: > > Fix rw->ro remount when there is a text vnode mapping. > > > > Reported and tested by: hrs > > Sponsored by: The FreeBSD Foundation > > MFC after: 16 days > > > > Modified: > > head/sys/kern/vfs_subr.c > > > > Modified: head/sys/kern/vfs_subr.c > > ============================================================================== > > --- head/sys/kern/vfs_subr.c Sun May 19 06:01:11 2019 (r347967) > > +++ head/sys/kern/vfs_subr.c Sun May 19 09:18:09 2019 (r347968) > > @@ -3146,7 +3146,7 @@ loop: > > > > if ((vp->v_type == VNON || > > (error == 0 && vattr.va_nlink > 0)) && > > - (vp->v_writecount == 0 || vp->v_type != VREG)) { > > + (vp->v_writecount <= 0 || vp->v_type != VREG)) { > > VOP_UNLOCK(vp, 0); > > vdropl(vp); > > continue; > > _______________________________________________ > > svn-src-all@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/svn-src-all > > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"