From owner-freebsd-net@FreeBSD.ORG Wed Jan 10 00:42:03 2007 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 10EBC16A412; Wed, 10 Jan 2007 00:42:03 +0000 (UTC) (envelope-from rnsanchez@wait4.org) Received: from sumo.dreamhost.com (sumo.dreamhost.com [66.33.216.29]) by mx1.freebsd.org (Postfix) with ESMTP id EF22813C44C; Wed, 10 Jan 2007 00:42:02 +0000 (UTC) (envelope-from rnsanchez@wait4.org) Received: from spunkymail-a14.dreamhost.com (sd-green-bigip-177.dreamhost.com [208.97.132.177]) by sumo.dreamhost.com (Postfix) with ESMTP id 51DF8178AE7; Tue, 9 Jan 2007 16:10:24 -0800 (PST) Received: from sauron.lan.box (unknown [200.180.177.239]) by spunkymail-a14.dreamhost.com (Postfix) with ESMTP id 15307190E2C; Tue, 9 Jan 2007 16:10:20 -0800 (PST) Date: Tue, 9 Jan 2007 22:10:19 -0200 From: Ricardo Nabinger Sanchez To: syrinx@FreeBSD.org Message-Id: <20070109221019.7e0e3303.rnsanchez@wait4.org> In-Reply-To: <61b573980701090838q415d6c6fx75b7de73eeace9fd@mail.gmail.com> References: <61b573980701090838q415d6c6fx75b7de73eeace9fd@mail.gmail.com> Organization: SYS_WAIT4 X-Mailer: Sylpheed 2.3.0 (GTK+ 2.10.6; i386-unknown-freebsd6.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: freebsd-net@freebsd.org Subject: Re: RFC: a MIB for a SNMP vlan monitoring module X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2007 00:42:03 -0000 On Tue, 9 Jan 2007 18:38:26 +0200 "Shteryana Shopova" wrote: > Work is about to start on a vlan monitoring module for bsnmpd(1) - I'm > attaching the private BEGEMOT MIB that the module will implement. Any > comments or suggestions are very welcome. I missed a column to track errors/corrupted packets in the begemotVlanIfStatsTable. :) Other than that, it looks nice to me. Some nits follow (mostly whitespace). I'd rather read "VLAN" instead of "vlan" throughout the descriptions, but I didn't change them. --- BEGEMOT-VLAN-MIB.txt.orig Tue Jan 9 21:48:51 2007 +++ BEGEMOT-VLAN-MIB.txt Tue Jan 9 22:03:47 2007 @@ -179,7 +179,7 @@ -- begemotVlanParentIfName object is redundant since its value can -- be obtained by a SNMP client by invoking a GET on the ifName -- object with an index of the corresponding value of --- begemotVlanTrunkIndex, but is included for convenience. +-- begemotVlanTrunkIndex, but is included for convenience. begemotVlanParentIfName OBJECT-TYPE SYNTAX OCTET STRING (SIZE(1..16)) @@ -280,7 +280,7 @@ begemotVlanIfStatus RowStatus, begemotVlanIfEncaplen INTEGER, begemotVlanIfMtuFudge INTEGER, - begemotVlanIfMinTU INTEGER + begemotVlanIfMinTU INTEGER } begemotVlanIfName OBJECT-TYPE @@ -333,7 +333,7 @@ STATUS current DESCRIPTION "The value by which the MTU is reduced on the parent - interface of this vlan interface." + interface of this vlan interface." ::= { begemotVlanInterfaceEntry 6 } begemotVlanIfMinTU OBJECT-TYPE @@ -341,7 +341,7 @@ MAX-ACCESS read-write STATUS current DESCRIPTION - "The minumum transmission unit of the vlan interface." + "The minimum transmission unit of the vlan interface." ::= { begemotVlanInterfaceEntry 7 } -- ---------------------------------------------------------- -- -- Ricardo Nabinger Sanchez Powered by FreeBSD "Left to themselves, things tend to go from bad to worse."