From nobody Tue Jun 23 14:45:40 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gl7Cd6YFGz6hWtN; Tue, 23 Jun 2026 14:45:33 +0000 (UTC) (envelope-from bcr@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gl7Cd4bdgz42Ph; Tue, 23 Jun 2026 14:45:33 +0000 (UTC) (envelope-from bcr@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782225933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5B4xHH7Lue4tbyC+WvfZCIN38mNrReIIAXfYuvv30v0=; b=JOCvYERfDLJu2/hDu4pyJ9mWoPZ+8nYvD+L0jWYfeLz8r5gudhjvi2+pKafCBkIG37GmYQ HdXCdEPQxohoGVS72AEfAcaP/rkt085Ryi939AHSMW3ShA3ww25tnfKtusEsBgSvUaYzlJ n2t83WiIhUs2YklHntNM/6XWaFidlrHa5Dn9OE3uJWkjgXjqqm0wBx9REXNF/lfl1TS3p7 rPgJOvf/jJ6WcXkTYAkIg/kVHwwzYr3MUhyOLEn9HgmuGUDIyq1GN5wLvbkuf8uaC0DygZ RnLY1/EZinnw6lY4Dmv3ftfMBtHh00aaQk/N4APO/JUE19p6m2JbtnSos9GaDA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782225933; a=rsa-sha256; cv=none; b=C2N2yoSNc3VEqaFnLF9ApqnNAS05232a+2vNmoAWAUZQ6K4pubs6V4ZWCaSmPoMS8r/SjG 8Xom4mYuwIiovcQX6j7u75o0qpxfbJKsPib2POxnWp/i+CGgoYHvmWMRE38Pt/Pihgw8A/ 36YdBxpzdc+IXBAsim79BsZEj39vZ2d3EM+LmiOks82ifsMriexfcdB0toLXEGnS6OmNv/ XjYjw3WO9NjRLE2yGrOeEPuMK4dE8+9RAiHfpSKeUxlzLBwN4ojTgKuBs5Wnp5r3C5eio+ UbwKBvr1Tetht/7XdN3PXabQmUo5AWDBp2BMwIfDss8VkJMZuisZmD/Ver4hgQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782225933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5B4xHH7Lue4tbyC+WvfZCIN38mNrReIIAXfYuvv30v0=; b=pNTGI/2jr9ac48NYiVLZP87F34ifsu+lFVTfy5W3Qz08LYp3HI6wTvVD6y4kpHDi4HQha0 /BJ7HOBqhblXtaBht80zXvN37qpb5UuwWaHWgn+kTUkJ99d0seLWaBv9B1ALin/c02Jzwm 3ULPljHTN4CzK1/xQTG4pUDFz8rNgLmrOfU7UOSbMDAB1AcmxmYHV02ArsJ110MaiVQ19k 9cf7cYUKjZkFN7+APg4EetMdhmBIL8MJBx51FLa3zmh6j4iRzYk5Q+BKBRF4/CqASRZ0Cq U9PDTwPGxHtWonpyx0XfkA/1QMhRqj2tHqwgofz+7XBNht/AABrwgaxs83qoNQ== Received: from [172.20.58.46] (unknown [134.190.58.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: bcr/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gl7Cd1zLpz14Qk; Tue, 23 Jun 2026 14:45:32 +0000 (UTC) (envelope-from bcr@freebsd.org) Message-ID: <7c836803-b1fe-4978-94ea-5ab37d1427d8@freebsd.org> Date: Tue, 23 Jun 2026 11:45:40 -0300 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 15a1ba4a1c46 - main - adduser.sh: Add info which separator to use in the question itself To: =?UTF-8?Q?Dag-Erling_Sm=C3=B8rgrav?= Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <6a3a8793.3a6b0.3f275318@gitrepo.freebsd.org> <86ldc5pbxq.fsf@ltc.des.dev> From: Benedict Reuschling In-Reply-To: <86ldc5pbxq.fsf@ltc.des.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Am 23.06.26 um 11:29 schrieb Dag-Erling Smørgrav: > Benedict Reuschling writes: >> commit 15a1ba4a1c467a686573158fd5e49abafa42d587 >> Author: Benedict Reuschling >> AuthorDate: 2026-06-23 13:13:44 +0000 >> Commit: Benedict Reuschling >> CommitDate: 2026-06-23 13:13:44 +0000 >> >> adduser.sh: Add info which separator to use in the question itself > We could just as easily normalize the separator: > > - [ -n "$_input" ] && ugroups="$_input" > + [ -n "$_input" ] && ugroups="$(echo "$_input" | tr -s ',' ' ')" > > DES That's true and would be the "src" way of solving it, rather than the "doc" way of describing what to do. I've seen instances where people even did "wheel, operator" (extra whitespace after the ","). I think when we actually tell people what to use as the separator, then we don't have to account for all kinds of varieties that users come up with to separate the groups (semicolons?). Ideally, the whole adduser.sh would be replaced by a sequence of bsddialogs (plus the parsing and checking), but that takes a bit more effort. Cheers, Benedict