From owner-cvs-ports@FreeBSD.ORG  Sun Jun  6 00:57:04 2004
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9F80E16A4CE; Sun,  6 Jun 2004 00:57:04 -0700 (PDT)
Received: from fillmore.dyndns.org (port-212-202-50-15.dynamic.qsc.de
	[212.202.50.15])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 66C1843D31; Sun,  6 Jun 2004 00:57:04 -0700 (PDT)
	(envelope-from eikemeier@fillmore-labs.com)
Received: from [172.16.0.2] (helo=fillmore-labs.com)
	by fillmore.dyndns.org with esmtp (Exim 4.34 (FreeBSD))
	id 1BWsWH-000MON-F9; Sun, 06 Jun 2004 09:56:43 +0200
Message-ID: <40C2CE39.5030402@fillmore-labs.com>
Date: Sun, 06 Jun 2004 09:56:41 +0200
From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
Organization: Fillmore Labs GmbH - http://www.fillmore-labs.com/
MIME-Version: 1.0
To: Joe Marcus Clarke <marcus@FreeBSD.org>
References: <200406060106.i5616XNX076254@repoman.freebsd.org>
In-Reply-To: <200406060106.i5616XNX076254@repoman.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
User-Agent: KMail/1.5.9
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/devel/portlint Makefileports/devel/portlint/src
 portlint.pl
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Jun 2004 07:57:04 -0000

Joe Marcus Clarke wrote:

>   * Check distinfo to make sure each file in DISTFILES has SIZE and MD5 entries
>     if NO_SIZE and NO_CHECKSUM are not defined

I believe this change serves no useful purpose and should be undone:

- no rule mandates the use of SIZE in distfiles. `make makesum' adds it by default,
  so if it is missing it is removed on purpose, e.g. to account for an mirror that
  has an broken http server.

- the patch does not check PATCHFILES

- the check fails for DISTFILES that use :group notation

- bsd.port.mk already checks whether distinfo is consitent in terms of existing MD5
  lines, no point in repeating this check in portlint

- the patch mandates SIZE lines for distfiles which are added to IGNOREFILES and have
  MD5 (...) = IGNORE, which makes no sense.

Generally patches like this should be checked with portlintgrep to see what ports
they flag, and whether they solve an existing or potential problem in the ports tree.

-Oliver