From owner-svn-src-head@FreeBSD.ORG Tue Jun 9 21:38:24 2009 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A3B56106564A; Tue, 9 Jun 2009 21:38:24 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 54EB48FC18; Tue, 9 Jun 2009 21:38:24 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id n59LYeL8051158; Tue, 9 Jun 2009 15:34:40 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Tue, 09 Jun 2009 15:34:59 -0600 (MDT) Message-Id: <20090609.153459.1820400761.imp@bsdimp.com> To: kmacy@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <3c1674c90906091012u26b0e823q57a7ea1f42eef22d@mail.gmail.com> References: <200904190016.n3J0G4rA090911@svn.freebsd.org> <20090609143729.R22887@maildrop.int.zabbadoz.net> <3c1674c90906091012u26b0e823q57a7ea1f42eef22d@mail.gmail.com> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, bz@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r191255 - in head/sys: amd64/conf conf i386/conf net X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2009 21:38:25 -0000 In message: <3c1674c90906091012u26b0e823q57a7ea1f42eef22d@mail.gmail.co= m> Kip Macy writes: : > I think FLOWTABLE does nto belong into DEFAULTS. =A0Really DEFAULTS= was : > meant for "You cannot boot without this" and if people start to wea= ken : > it, DEFAULTS will soon be the new GENERIC. =A0That said I am not su= re it : > belongs to GENERIC either. : = : I can either push it in to GENERIC or I can change it to NOFLOWTABLE.= : If you want to remove it from GENERIC then we're going to have to hav= e : a lengthy discussion about what most FreeBSD users actually use and : gut GENERIC as it stands now. The fact is, most FreeBSD users have : sufficiently few peers that flowtable is a win over using the routing= : table on every lookup. NO. NOFLOWTABLE is bogus. Negative options are lame. We need to have fewer of them rather than more. Also, we do *NOT* want it to be default on *ALL* platforms, which is what NOFLOWTABLE does. It should be in GENERIC, on a per-platform basis, if it is really ready for prime time. Embedded targets don't want this kind of stuff at all. People do mix/match generic, and having all the options there is the right way to do this. It is what people expect and having some odd-ball options like this makes it harder. In fact, it makes it harder to transition between releases because some options are 'magically on' and others need to be updated. It is a big pain. The project has decided in the past to have the options be normal, opt-in. Please, make this a normal option, and we can have the discussion about which config files it belongs in. Warner P.S. I see that you've made it a negative option later in the day from this message. I'm formally requesting that you back that out and make it a normal option.