From owner-dev-commits-src-main@freebsd.org Fri Jun 11 16:54:28 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 723AB661A94; Fri, 11 Jun 2021 16:54:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4G1n4h2cB6z3sXH; Fri, 11 Jun 2021 16:54:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 39FC6265FB; Fri, 11 Jun 2021 16:54:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 15BGsSkh035592; Fri, 11 Jun 2021 16:54:28 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 15BGsS1u035591; Fri, 11 Jun 2021 16:54:28 GMT (envelope-from git) Date: Fri, 11 Jun 2021 16:54:28 GMT Message-Id: <202106111654.15BGsS1u035591@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: a3238e92d704 - main - style: Relax 80 column rule MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a3238e92d704e84e70cc696a1cd2219fa4e4aa9e Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2021 16:54:28 -0000 The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=a3238e92d704e84e70cc696a1cd2219fa4e4aa9e commit a3238e92d704e84e70cc696a1cd2219fa4e4aa9e Author: Warner Losh AuthorDate: 2021-06-11 16:37:36 +0000 Commit: Warner Losh CommitDate: 2021-06-11 16:54:06 +0000 style: Relax 80 column rule Note that the 80 column rule has been relaxed for some time when things are clearer when a little longer. Add in that things that people grep for, such as error messages, shouldn't be broken up which is the most common reason people exceed 80 columns intentionally. Reviewed by: jhb, domagoj.stolfa@gmail.com Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D30255 --- share/man/man9/style.9 | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/share/man/man9/style.9 b/share/man/man9/style.9 index 9744b1c11a45..77c8dbe8e7d7 100644 --- a/share/man/man9/style.9 +++ b/share/man/man9/style.9 @@ -36,6 +36,10 @@ This file specifies the preferred style for kernel source files in the .Fx source tree. It is also a guide for the preferred userland code style. +The preferred line width is 80 characters, but some exceptions are +made when a slightly longer line is clearer or easier to read. +Anything that is frequently grepped for, such as diagnostic, error or panic +messages, should not be broken up over multiple lines despite this rule. Many of the style rules are implicit in the examples. Be careful to check the examples before assuming that .Nm