From owner-svn-src-stable-7@FreeBSD.ORG Mon Apr 13 20:19:28 2009 Return-Path: Delivered-To: svn-src-stable-7@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DAE7F106566C; Mon, 13 Apr 2009 20:19:28 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id C96BA8FC15; Mon, 13 Apr 2009 20:19:28 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n3DKJS2n082384; Mon, 13 Apr 2009 20:19:28 GMT (envelope-from bz@svn.freebsd.org) Received: (from bz@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n3DKJS5G082383; Mon, 13 Apr 2009 20:19:28 GMT (envelope-from bz@svn.freebsd.org) Message-Id: <200904132019.n3DKJS5G082383@svn.freebsd.org> From: "Bjoern A. Zeeb" Date: Mon, 13 Apr 2009 20:19:28 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org X-SVN-Group: stable-7 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r191014 - stable/7/usr.sbin/ppp X-BeenThere: svn-src-stable-7@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 7-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2009 20:19:30 -0000 Author: bz Date: Mon Apr 13 20:19:28 2009 New Revision: 191014 URL: http://svn.freebsd.org/changeset/base/191014 Log: MFC r186308 by qingli: The ppp application relies on the if_tun interface to properly install a ptp host route between the end points. The ppp module upates this router based on user configuration later on. The rt_Update() seems to always set the RTF_GATEWAY flag, which is broken. PR: bin/130159 Approved by: re (kensmith) Modified: stable/7/usr.sbin/ppp/ (props changed) stable/7/usr.sbin/ppp/route.c Modified: stable/7/usr.sbin/ppp/route.c ============================================================================== --- stable/7/usr.sbin/ppp/route.c Mon Apr 13 19:54:33 2009 (r191013) +++ stable/7/usr.sbin/ppp/route.c Mon Apr 13 20:19:28 2009 (r191014) @@ -902,8 +902,10 @@ rt_Update(struct bundle *bundle, const s p += memcpy_roundup(p, dst, dst->sa_len); } - rtmes.m_rtm.rtm_addrs |= RTA_GATEWAY; + if (gw != NULL && (gw->sa_family != AF_LINK)) + rtmes.m_rtm.rtm_addrs |= RTA_GATEWAY; p += memcpy_roundup(p, gw, gw->sa_len); + if (mask) { rtmes.m_rtm.rtm_addrs |= RTA_NETMASK; p += memcpy_roundup(p, mask, mask->sa_len);