From owner-cvs-all@FreeBSD.ORG Wed Jan 11 17:48:46 2012 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E71C2106566B; Wed, 11 Jan 2012 17:48:45 +0000 (UTC) (envelope-from glarkin@FreeBSD.org) Received: from mail1.sourcehosting.net (mail1.sourcehosting.net [74.205.51.45]) by mx1.freebsd.org (Postfix) with ESMTP id B307B8FC14; Wed, 11 Jan 2012 17:48:45 +0000 (UTC) Received: from 68-189-245-235.dhcp.oxfr.ma.charter.com ([68.189.245.235] helo=imac.entropy.prv) by mail1.sourcehosting.net with esmtp (Exim 4.73 (FreeBSD)) (envelope-from ) id 1Rl2Hk-000DWI-7a; Wed, 11 Jan 2012 12:48:39 -0500 Received: from imac.entropy.prv (localhost [127.0.0.1]) by imac.entropy.prv (Postfix) with ESMTP id CF113D6CC23; Wed, 11 Jan 2012 12:48:33 -0500 (EST) Message-ID: <4F0DCB71.3060204@FreeBSD.org> Date: Wed, 11 Jan 2012 12:48:33 -0500 From: Greg Larkin Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.25) Gecko/20111213 Lightning/1.0b2 Thunderbird/3.1.17 MIME-Version: 1.0 To: Doug Barton References: <201201061944.q06JiwUR048089@repoman.freebsd.org> <4F0BF9F3.40009@FreeBSD.org> <4F0C2E7C.6070802@FreeBSD.org> <4F0CC4DF.6030906@FreeBSD.org> <4F0DB4F5.7020906@FreeBSD.org> <4F0DC833.6000705@FreeBSD.org> In-Reply-To: <4F0DC833.6000705@FreeBSD.org> X-Enigmail-Version: 1.1.1 OpenPGP: id=1C940290 X-SA-Exim-Connect-IP: 68.189.245.235 X-SA-Exim-Mail-From: glarkin@FreeBSD.org X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail1.sourcehosting.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=AWL, BAYES_00, RCVD_IN_RP_RNBL, RCVD_IN_SORBS_DUL,RDNS_DYNAMIC,TVD_RCVD_IP autolearn=no version=3.3.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SA-Exim-Version: 4.2 X-SA-Exim-Scanned: Yes (on mail1.sourcehosting.net) Cc: Michael Scheidell , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, Gabor Kovesdan , raven428@gmail.com, cvs-ports@FreeBSD.org Subject: Re: cvs commit: ports/devel/pinba_engine Makefile distinfo ports/devel/pinba_engine/files patch-src__ha_pinba.cc X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: glarkin@FreeBSD.org List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2012 17:48:46 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 1/11/12 12:34 PM, Doug Barton wrote: > On 1/11/2012 8:12 AM, Greg Larkin wrote: >> On 1/10/12 6:08 PM, Doug Barton wrote: > >>> The correct fix is probably to remove that line and add something like >>> (untested): >> >>> .if ${MYSQL_VER} == 52 >>> MYSQL_PORTDIR= ${PORTSDIR}/databases/mariadb-server >>> .else >>> MYSQL_PORTDIR= ${PORTSDIR}/databases/mysql${MYSQL_VER}-server >>> .endif >> >>> That should allow it to work with mariadb. >> >> Hi Doug, >> >> The line "${NONEXISTENT}:${MYSQL_PORTDIR}:configure" has been there >> since the initial import, > > I was only going by the latest version of 'cvs annotate,' I didn't do an > exhaustive search. Sorry if I created confusion about when/who, etc. > >> and the ":configure" portion adheres to the >> description here: >> http://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.html#AEN2138. > > Yeah, someone clued me in about that on IRC, but thanks. Just to be > clear, I am not concerned about how the port does its thing. My only > concern is that it work with mariadb. > >> Can you post the errors from the INDEX build? > > /usr/ports/devel/pinba_engine (pinba_engine-2011.08.18_1) Error. > BUILD_DEPENDS /usr/ports/databases/mysql52-server -- dependency not found > > But once again, that's just a symptom. If the user sets WITH_MYSQL_VER= > 52 in their make.conf this port will not build. > >> Since Pinba now supports MySQL 5.1.x+ and MariaDB 5.1.43+, the better >> solution may be to present options to the user to select the database >> backend, > > Um, no, that's exactly what should _not_ be done. :) The ports > infrastructure already has a method for users to select what mysql > version they want to use. This port needs to be made to work with it. > That's all. > > Do you have a philosophical objection to the snippet I pasted in my last > message? It's not pretty but I don't see why it wouldn't work, and > provide minimal disruption to the way the port is structured currently. > Nope, that's fine with me then. Thank you, Greg - -- Greg Larkin http://www.FreeBSD.org/ - The Power To Serve http://www.sourcehosting.net/ - Ready. Set. Code. http://twitter.com/cpucycle/ - Follow you, follow me -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8Ny3EACgkQ0sRouByUApBoVACgqXwzs69cpNk8QuIkA5m8Ke9e PpsAniskohHNcOgOSaUXSAlQDL+b+p7K =49cY -----END PGP SIGNATURE-----