From owner-svn-src-head@FreeBSD.ORG Wed Oct 13 22:23:18 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 68A58106566B; Wed, 13 Oct 2010 22:23:18 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id 45CF68FC16; Wed, 13 Oct 2010 22:23:18 +0000 (UTC) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.4/8.14.4) with ESMTP id o9DMNHlN017256; Wed, 13 Oct 2010 15:23:17 -0700 (PDT) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.4/8.14.4/Submit) id o9DMNHER017255; Wed, 13 Oct 2010 15:23:17 -0700 (PDT) (envelope-from obrien) Date: Wed, 13 Oct 2010 15:23:17 -0700 From: "David O'Brien" To: John Baldwin Message-ID: <20101013222317.GB17164@dragon.NUXI.org> References: <201010121924.o9CJOgwn059485@svn.freebsd.org> <20101013040543.GB13694@dragon.NUXI.org> <20101013152037.S2102@besplex.bde.org> <201010130907.59715.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201010130907.59715.jhb@freebsd.org> X-Operating-System: FreeBSD 9.0-CURRENT X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? User-Agent: Mutt/1.5.16 (2007-06-09) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Bruce Evans Subject: Re: svn commit: r213744 - head/bin/sh X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Oct 2010 22:23:18 -0000 On Wed, Oct 13, 2010 at 09:07:59AM -0400, John Baldwin wrote: > To be honest, I think changing STATIC is excessive churn. At this point I'm just making everything consistently "static" so that folks that add to ash won't need to realize that "STATIC" exists. Some of the folks making various FreeBSD changes did not realize this and created inconsistencies. Surely this inconsistency isn't desired. > The "right" fix > is to use 'make DEBUG_FLAGS="-g -DDEBUG=2 -fno-inline"'. I often use > 'make DEBUG_FLAGS="-g -fno-inline"' to workaround excessive inlining when I've added "-fno-inline" to DEBUG_FLAGS and will leave it up to others if that spelling isn't accepted by clang, Intel C, or what ever compiler someone may want to use. -- -- David (obrien@FreeBSD.org)