From owner-freebsd-hackers@FreeBSD.ORG Mon Mar 10 18:23:36 2014 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 442E31AD; Mon, 10 Mar 2014 18:23:36 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E686CCAF; Mon, 10 Mar 2014 18:23:35 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id s2AINX2S072474 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 10 Mar 2014 11:23:34 -0700 (PDT) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id s2AINXXk072473; Mon, 10 Mar 2014 11:23:33 -0700 (PDT) (envelope-from jmg) Date: Mon, 10 Mar 2014 11:23:33 -0700 From: John-Mark Gurney To: Baptiste Daroussin Subject: Re: [CFR] Kevent timer improvements Message-ID: <20140310182333.GJ32089@funkthat.com> Mail-Followup-To: Baptiste Daroussin , hackers@freebsd.org, desrt@desrt.ca References: <20140310131632.GI6900@ithaqua.etoilebsd.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140310131632.GI6900@ithaqua.etoilebsd.net> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Mon, 10 Mar 2014 11:23:34 -0700 (PDT) Cc: desrt@desrt.ca, hackers@freebsd.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Mar 2014 18:23:36 -0000 Baptiste Daroussin wrote this message on Mon, Mar 10, 2014 at 14:16 +0100: > A glib developer pointed me to some of the improvements Apple has done on > kqueue(2), some of those improvements are used or will be used by glib in the > near futur, plus add new one. > > I decided to implement part of it and here is the first patch about it: > http://people.freebsd.org/~bapt/kevent.diff > > I will update the manpages accordingly as well: > > Basically this patch added the following to the EVFILT_TIMER: > NOTE_SECONDS data is in seconds > NOTE_USECONDS data is in microseconds > NOTE_NSECONDS data is in nanoseconds Could you contact the maintainer of sbintime and look at adding an SBINTIME_MAX/_MIN define macros and use those instead of INT64_MAX? We shouldn't know the internal implementation type of sbintime_t in the code in case the type changes... > I do plan to add kevent64 support compatible with apple implementation later, as > using NOTE_MONOTONIC without 64bit support is not useful very long :) Is this just to support 64bit data on a 32bit system? Also, why is ident grown to 64bits? I don't see any filters that could possibly need the additional range... I can understand data be expanded to 64bits... Also, what exactly is ext used for? I'm looking at MacOSX's description of ext, and it isn't clear.. it basicly says "ext[0] is passed through much like udata" (only much? not exactly like?), and "ext[1] can always be used like udata"... It isn't clear how/what these are used for, etc.. It looks like the "much like udata" part is because using the EVFILT_MACHPORT will overwrite it. If we do import this, I'd like to be clear on how they are used, i.e. their use is specified by the filter, and if the filter does not use them, they are exactly like additional udata fields.. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."