From owner-svn-src-all@FreeBSD.ORG  Fri Jan  4 11:34:10 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id E77147DD;
 Fri,  4 Jan 2013 11:34:10 +0000 (UTC)
 (envelope-from mjguzik@gmail.com)
Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50])
 by mx1.freebsd.org (Postfix) with ESMTP id EA68AD7A;
 Fri,  4 Jan 2013 11:34:09 +0000 (UTC)
Received: by mail-wg0-f50.google.com with SMTP id es5so7675602wgb.29
 for <multiple recipients>; Fri, 04 Jan 2013 03:34:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=x-received:date:from:to:cc:subject:message-id:references
 :mime-version:content-type:content-disposition:in-reply-to
 :user-agent; bh=fAOViSm/l7fvZ/0fa1ezUqN7CqiImDeKm8T58JhRwvs=;
 b=J2Lv8UaufI8oewkNw0CK1+17uTR2O19+zBum/M6iDMeF10OKVNZlxtUqcl0jSOt3JR
 JrMlg81/oMH76qFTG37TBY3hgC6G/gUtf7PLjxeAYnP7m/425R75NhLaG+RVArbHfrGB
 rNA/FJotu+U/YkbodpVPIz+/o/3B81dn09B347rfwCGHc36M+MqJcrOKA0QXeEvqIIxX
 RAB5TJBVoh+kIOprQYTqYbHS2e8qNmw4i9bTZfwfsorzleUpKkvShZc42LsVdaxvzTtA
 n2eh3TP1sfoaYDxIxzVjeMmf+sZr4V8KP4pIq3XngMRmQP9zp9LKStlcrYaWDoWrO+W7
 f9/Q==
X-Received: by 10.180.93.133 with SMTP id cu5mr72553842wib.32.1357299248715;
 Fri, 04 Jan 2013 03:34:08 -0800 (PST)
Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net.
 [2001:470:1f08:1f7::2])
 by mx.google.com with ESMTPS id hu8sm71515049wib.6.2013.01.04.03.34.03
 (version=TLSv1/SSLv3 cipher=OTHER);
 Fri, 04 Jan 2013 03:34:07 -0800 (PST)
Date: Fri, 4 Jan 2013 12:33:54 +0100
From: Mateusz Guzik <mjguzik@gmail.com>
To: David Xu <davidxu@FreeBSD.org>
Subject: Re: svn commit: r245036 - head/sys/kern
Message-ID: <20130104113354.GB26239@dft-labs.eu>
References: <201301041111.r04BBDjZ013380@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <201301041111.r04BBDjZ013380@svn.freebsd.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jan 2013 11:34:11 -0000

On Fri, Jan 04, 2013 at 11:11:13AM +0000, David Xu wrote:
> Author: davidxu
> Date: Fri Jan  4 11:11:12 2013
> New Revision: 245036
> URL: http://svnweb.freebsd.org/changeset/base/245036
> 
> Log:
>   Revert revision 244760 because strncpy pads trailing space with zero,
>   this prevents kernel data from being leaked.
>   

I think it would be better to teach strlcpy to zero-pad as well.

-- 
Mateusz Guzik <mjguzik gmail.com>