From owner-svn-src-all@FreeBSD.ORG Sun Dec 29 00:40:33 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9DBD2EC for ; Sun, 29 Dec 2013 00:40:33 +0000 (UTC) Received: from mail-pd0-x233.google.com (mail-pd0-x233.google.com [IPv6:2607:f8b0:400e:c02::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6C6AC17C4 for ; Sun, 29 Dec 2013 00:40:33 +0000 (UTC) Received: by mail-pd0-f179.google.com with SMTP id r10so10243273pdi.10 for ; Sat, 28 Dec 2013 16:40:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wemm.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=2LrDuxz4Qy5swbfvslnDXc7wTjiovmHtF9+3qmU4dKY=; b=lGGMVKYeFQJu60i+2Ftdz3sRpf/SNVpA09kUy95EHm766a6dNKliGua3WnEI0j3uLv IEHiLjFxbKSLkuHd5F0y/YbwpDtMdS8fCanmYpBww8oNHHU7/2sXN0cQW+uWUfZTMK6Y DUpucI4DgQXA+2AHUqkaj57k0p3A8Z+IsOpC0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=2LrDuxz4Qy5swbfvslnDXc7wTjiovmHtF9+3qmU4dKY=; b=U0tMKzozaF11iAj8Hxt4Wg6iH39C67WPS+DsuEtYfwpgAYlNj7qyUZPL95IXUVVEXw PU1Imf/k7MT4uI1mUn07cGPvDfk/T6HXEUmoXkcs8rcbOxR66hA7xhWv4xY8CinZ8ai+ xqv5r6zdH3jbVjQKHAhNCHpfwMLvQ8gBC8HgNaj/oNaNYce8FEvcrtm9gnGnqhljf8QO 34Y8qTuuwdp8xxObUte1FkSRppll0HzF5aJDPqDK1SspOannfcelTNQKDhhn44ZS+wNG m78CniyhNEl0MtK/Sq63Bs/AAsFi7i3l0e25JbkFh9WUyVWP0vZTEWmoes7BPWiLdM9t TI+w== X-Gm-Message-State: ALoCoQlV9TE+q7ExSUOT4Fkwzv8lywo96biCaPSozSSCLKZef7rF9hx8pZwQETVhQe7QVuijin6d MIME-Version: 1.0 X-Received: by 10.66.137.109 with SMTP id qh13mr42969038pab.140.1388277632890; Sat, 28 Dec 2013 16:40:32 -0800 (PST) Received: by 10.66.162.3 with HTTP; Sat, 28 Dec 2013 16:40:32 -0800 (PST) In-Reply-To: References: <201312282301.rBSN1wWP002326@svn.freebsd.org> Date: Sat, 28 Dec 2013 16:40:32 -0800 Message-ID: Subject: Re: svn commit: r260022 - head/lib/libkvm From: Peter Wemm To: Marcel Moolenaar Content-Type: text/plain; charset=ISO-8859-1 Cc: "svn-src-head@freebsd.org" , svn-src-all , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2013 00:40:33 -0000 On Sat, Dec 28, 2013 at 4:04 PM, Peter Wemm wrote: > On Sat, Dec 28, 2013 at 3:01 PM, Marcel Moolenaar wrote: >> Author: marcel >> Date: Sat Dec 28 23:01:57 2013 >> New Revision: 260022 >> URL: http://svnweb.freebsd.org/changeset/base/260022 >> >> Log: >> Allow building a cross libkvm by setting TARGET_ARCH. The library so >> produced will be called libkvm-${ARCH} instead of libkvm. This allows >> installing it alongside the native version. >> For symbol lookups, use ps_pglobal_lookup() instead of __fdnlist() >> when building a cross libkvm. It is assumed that the cross tool that >> uses the cross libkvm also provides an implementation for this >> proc_services function. >> >> Note that this commit does not change any of the architecture-specific >> code for cross-compilation. > > Are you sure about this? I just got a brand new buildworld failure on > an amd64 machine. The lib32 build code was trying to use 64 bit pmap > definitions and failed miserably. > > I'm really sorry, I accidentally blew away the failure log. I'll have > another in a few minutes. This is from stage5.1, the lib32 build: /usr/src/lib/libkvm/kvm_amd64.c:78:2: error: unknown type name 'pml4_entry_t' pml4_entry_t *PML4; ^ /usr/src/lib/libkvm/kvm_amd64.c:153:2: error: use of undeclared identifier 'pml4_entry_t' pml4_entry_t *PML4; ^ /usr/src/lib/libkvm/kvm_amd64.c:153:16: error: use of undeclared identifier 'PML4' pml4_entry_t *PML4; ^ /usr/src/lib/libkvm/kvm_amd64.c:200:2: error: use of undeclared identifier 'PML4' PML4 = _kvm_malloc(kd, PAGE_SIZE); ^ /usr/src/lib/libkvm/kvm_amd64.c:201:23: error: use of undeclared identifier 'PML4' if (kvm_read(kd, pa, PML4, PAGE_SIZE) != PAGE_SIZE) { ^ /usr/src/lib/libkvm/kvm_amd64.c:205:19: error: use of undeclared identifier 'PML4' kd->vmst->PML4 = PML4; ^ /usr/src/lib/libkvm/kvm_amd64.c:217:2: error: use of undeclared identifier 'pml4_entry_t' pml4_entry_t pml4e; ^ /usr/src/lib/libkvm/kvm_amd64.c:218:2: error: unknown type name 'pdp_entry_t'; did you mean 'pd_entry_t'? pdp_entry_t pdpe; ^~~~~~~~~~~ pd_entry_t /usr/obj/usr/src/lib32/usr/include/machine/pmap.h:175:18: note: 'pd_entry_t' declared here typedef uint32_t pd_entry_t; ^ /usr/src/lib/libkvm/kvm_amd64.c:246:22: error: use of undeclared identifier 'PML4SHIFT' pml4eindex = (va >> PML4SHIFT) & (NPML4EPG - 1); ^ /usr/src/lib/libkvm/kvm_amd64.c:246:36: error: use of undeclared identifier 'NPML4EPG' pml4eindex = (va >> PML4SHIFT) & (NPML4EPG - 1); ^ /usr/src/lib/libkvm/kvm_amd64.c:247:2: error: use of undeclared identifier 'pml4e' pml4e = vm->PML4[pml4eindex]; ^ /usr/src/lib/libkvm/kvm_amd64.c:248:15: error: use of undeclared identifier 'pml4e' if (((u_long)pml4e & PG_V) == 0) { ^ /usr/src/lib/libkvm/kvm_amd64.c:253:21: error: use of undeclared identifier 'PDPSHIFT' pdpeindex = (va >> PDPSHIFT) & (NPDPEPG-1); ^ /usr/src/lib/libkvm/kvm_amd64.c:253:34: error: use of undeclared identifier 'NPDPEPG' pdpeindex = (va >> PDPSHIFT) & (NPDPEPG-1); ^ /usr/src/lib/libkvm/kvm_amd64.c:254:21: error: use of undeclared identifier 'pml4e' pdpe_pa = ((u_long)pml4e & PG_FRAME) + ^ /usr/src/lib/libkvm/kvm_amd64.c:255:26: error: use of undeclared identifier 'pdp_entry_t'; did you mean 'pd_entry_t'? (pdpeindex * sizeof(pdp_entry_t)); ^ 16 errors generated. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI6FJV Yes, I know, gmail sucks now. If you see this then I forgot. Habits are hard to break.