From nobody Tue Jun 20 21:56:11 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qm0p33KYkz4g26v; Tue, 20 Jun 2023 21:56:27 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qm0p26lTyz3NGZ; Tue, 20 Jun 2023 21:56:26 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-3a0457d6b77so196930b6e.0; Tue, 20 Jun 2023 14:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687298184; x=1689890184; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Elg8rC20gYDiErlEWWtuXYbwxhc0hljUX1kXnMrlWsE=; b=VMQhJwQ5E6ZOi23ovGnG+DoIKYjGCu25MMpW+zUpd+i1NdnKUB1BFtbvBeQ3YLbjX+ AtV/JlDzohm+Yyvt4yFR//JViE/L07TT9AWdNv7iF1QUiYAd7/ZNupMmVdlFXKjCJdCQ 6guAAczktHBDjP6BwIwDFqw93IC7MGo/VkaLtvwWSF8mHkHPOXwpiEItWSLepZGt6ZEx n81l1OYyYZaYe9wtIwLayeXtTzJU2W38+x6JRg77i52CZyOb+fFs0s8IEkkYM2TtvZGb dSktqbtBmZV2atEh0I0z1OoBB/h0WylCLjjaRT4M79BQpfWzXvxIKZRX8Q+cZtJ1QV3/ ArOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687298184; x=1689890184; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Elg8rC20gYDiErlEWWtuXYbwxhc0hljUX1kXnMrlWsE=; b=HWcmX7wqfsT6WN46QO563rCs9AGooYUoMXVmv+9BVMtMGcAL0xleLWIlpN7Mr/LCtE 4ugbu4dP2sx9vWPCj29GeOsYgviWOFdADKzT7srFBfyiOhSH74FcVznaIq0DUA1Do69n TnBEEvvaTpDSsMyJyvWV2x97YN6wWLlFgya6ulzE69cevrAIPzA/tQ4pW05EmVX+FQQU CQG+xwcFp3YjIv3MbjPigStBEgdOy84fSPKuRWae7PLtdW80PFTJ821jvJdsHHHLZPHk 2+BvjY1B976zAJ4iF5Dtuup9IWSTM8Kyrtd99JrlB0o8ekhhe8wowTew46Tu+XW0dG0s amKg== X-Gm-Message-State: AC+VfDyyAsbow3zYJd0Lz2+NorvZpDITfx4rXk0JUrQG9n6U6HWtKw5h AlkgFN87CX3CsBkUmvSuY+f8VWVdqi4x4LTjIBpXxMwlvIGTZIezUelnOA== X-Google-Smtp-Source: ACHHUZ5jQhWr3mSNjltYG1Xg+8w3qkGd4Brpvq47N0nKereSUvbsuSJxiFT+nZt6QMp72lnhpOKMCgPsDaCy3ETWtcY= X-Received: by 2002:a05:6808:1797:b0:39e:c9f0:8fde with SMTP id bg23-20020a056808179700b0039ec9f08fdemr6124178oib.19.1687298184512; Tue, 20 Jun 2023 14:56:24 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202306201629.35KGTDxK044992@gitrepo.freebsd.org> In-Reply-To: <202306201629.35KGTDxK044992@gitrepo.freebsd.org> From: Benjamin Kaduk Date: Tue, 20 Jun 2023 14:56:11 -0700 Message-ID: Subject: Re: git: 2e2a1c8ecf63 - main - libgssapi: Remove set but unused variable. To: John Baldwin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000eb09cd05fe96b84f" X-Rspamd-Queue-Id: 4Qm0p26lTyz3NGZ X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000eb09cd05fe96b84f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 20, 2023 at 9:29=E2=80=AFAM John Baldwin wrot= e: > The branch main has been updated by jhb: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D2e2a1c8ecf639317f40cdb1c2a0c5b9= abe990e58 > > commit 2e2a1c8ecf639317f40cdb1c2a0c5b9abe990e58 > Author: John Baldwin > AuthorDate: 2023-06-20 16:28:59 +0000 > Commit: John Baldwin > CommitDate: 2023-06-20 16:28:59 +0000 > > libgssapi: Remove set but unused variable. > > Reported by: GCC > --- > lib/libgssapi/gss_delete_sec_context.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/lib/libgssapi/gss_delete_sec_context.c > b/lib/libgssapi/gss_delete_sec_context.c > index 930f51399cce..b64e32c5dc2c 100644 > --- a/lib/libgssapi/gss_delete_sec_context.c > +++ b/lib/libgssapi/gss_delete_sec_context.c > @@ -41,7 +41,6 @@ gss_delete_sec_context(OM_uint32 *minor_status, > gss_ctx_id_t *context_handle, > gss_buffer_t output_token) > { > - OM_uint32 major_status; > struct _gss_context *ctx =3D (struct _gss_context *) *context_han= dle; > > if (output_token) > @@ -54,7 +53,7 @@ gss_delete_sec_context(OM_uint32 *minor_status, > * otherwise fake an empty token. > */ > if (ctx->gc_ctx) { > - major_status =3D ctx->gc_mech->gm_delete_sec_cont= ext( > + (void) ctx->gc_mech->gm_delete_sec_context( > Looks like gcc was catching a latent bug here -- if we consult the corresponding heimdal implementation, major_status is initialized to GSS_S_COMPLETE but this assignment can override it, and the function itself returns major_status rather than a hardcoded GSS_S_COMPLETE. -Ben > minor_status, &ctx->gc_ctx, output_token)= ; > } > free(ctx); > > --000000000000eb09cd05fe96b84f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Jun 20, 2023 at 9:29=E2=80=AFAM J= ohn Baldwin <jhb@freebsd.org> = wrote:
The branch main has been updated by jhb:

URL: https://cgit.= FreeBSD.org/src/commit/?id=3D2e2a1c8ecf639317f40cdb1c2a0c5b9abe990e58
commit 2e2a1c8ecf639317f40cdb1c2a0c5b9abe990e58
Author:=C2=A0 =C2=A0 =C2=A0John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2023-06-20 16:28:59 +0000
Commit:=C2=A0 =C2=A0 =C2=A0John Baldwin <jhb@FreeBSD.org>
CommitDate: 2023-06-20 16:28:59 +0000

=C2=A0 =C2=A0 libgssapi: Remove set but unused variable.

=C2=A0 =C2=A0 Reported by:=C2=A0 =C2=A0 GCC
---
=C2=A0lib/libgssapi/gss_delete_sec_context.c | 3 +--
=C2=A01 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/libgssapi/gss_delete_sec_context.c b/lib/libgssapi/gss_del= ete_sec_context.c
index 930f51399cce..b64e32c5dc2c 100644
--- a/lib/libgssapi/gss_delete_sec_context.c
+++ b/lib/libgssapi/gss_delete_sec_context.c
@@ -41,7 +41,6 @@ gss_delete_sec_context(OM_uint32 *minor_status,
=C2=A0 =C2=A0 =C2=A0gss_ctx_id_t *context_handle,
=C2=A0 =C2=A0 =C2=A0gss_buffer_t output_token)
=C2=A0{
-=C2=A0 =C2=A0 =C2=A0 =C2=A0OM_uint32 major_status;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 struct _gss_context *ctx =3D (struct _gss_conte= xt *) *context_handle;

=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (output_token)
@@ -54,7 +53,7 @@ gss_delete_sec_context(OM_uint32 *minor_status,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* otherwise f= ake an empty token.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*/
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (ctx->gc_ctx)= {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0major_status =3D ctx->gc_mech->gm_delete_sec_context(
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0(void) ctx->gc_mech->gm_delete_sec_context(

Looks like gcc was catching a latent bug h= ere -- if we consult the corresponding heimdal implementation, major_status= is initialized to GSS_S_COMPLETE but this assignment can override it, and = the function itself returns major_status rather than a hardcoded GSS_S_COMP= LETE.

-Ben

=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 minor_status, &ctx->gc_ctx, output_token);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 free(ctx);

--000000000000eb09cd05fe96b84f--