From owner-freebsd-ports@FreeBSD.ORG Fri Feb 18 06:58:25 2005 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 46A3216A4CE; Fri, 18 Feb 2005 06:58:25 +0000 (GMT) Received: from voodoo.oberon.net (voodoo.oberon.net [212.118.165.100]) by mx1.FreeBSD.org (Postfix) with ESMTP id E0E1F43D39; Fri, 18 Feb 2005 06:58:24 +0000 (GMT) (envelope-from krion@voodoo.oberon.net) Received: from krion by voodoo.oberon.net with local (Exim 4.44 (FreeBSD)) id 1D225o-0006Uw-Cn; Fri, 18 Feb 2005 07:58:24 +0100 Date: Fri, 18 Feb 2005 07:58:24 +0100 From: Kirill Ponomarew To: Brian Fundakowski Feldman Message-ID: <20050218065824.GC13120@voodoo.oberon.net> References: <20050217204306.GA1116@green.homeunix.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050217204306.GA1116@green.homeunix.org> X-NCC-Regid: de.oberon X-NIC-HDL: KP869-RIPE Keywords: 579279786 cc: ports@FreeBSD.org Subject: Re: portsperf (bsd.port.mk performance bugs fixed) redux X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Feb 2005 06:58:25 -0000 On Thu, Feb 17, 2005 at 03:59:13PM -0500, Brian Fundakowski Feldman wrote: > Well, guys, it's been a while since the last installment of portsperf. > Without further ado, here's a fix that bring port vulnerability check > time down from almost two minutes to almost instantaneous (on my > machine)! I was always wondering why ports have been so terribly slow > since around some time last year, and a good 2000 pids get recycled > just doing "make extract": > <@green_> now: > <@green_> green# time make extract > <@green_> ===> Extracting for mp3gain-1.3.2 > <@green_> => Checksum OK for mp3gain132_src.zip. > <@green_> ===> mp3gain-1.3.2 depends on executable: unzip - found > <@green_> 0.127u 1.132s 0:01.49 83.8% 108+497k 15+0io 8pf+0w > > <@green_> then: > <@green_> green# time make extract > <@green_> ===> Extracting for mp3gain-1.3.2 > <@green_> => Checksum OK for mp3gain132_src.zip. > <@green_> ===> mp3gain-1.3.2 depends on executable: unzip - found > <@green_> 5.308u 82.765s 1:42.05 86.2% 92+193k 10+0io 12pf+0w > > Only problem I know of is that on systems with a good enough version > of the pkg_* tools, an obsolete and broken version (specifically, on > 6.0, a version from a year ago) never reports itself as being obsolete > so it can get removed. The pkg_version -T functionality is broken, > then, without a hint to the operator that intervention must occur. > Is that why this change hasn't been made already? Because the patch is not quite correct and can't handle [&%?] chars in distinfo ? Hey, and you even know it :) -Kirill