From owner-freebsd-current Thu Jan 27 8:53:52 2000 Delivered-To: freebsd-current@freebsd.org Received: from relay.ucb.crimea.ua (UCB-Async4-CRISCO.CRIS.NET [212.110.129.130]) by hub.freebsd.org (Postfix) with ESMTP id 0F6ED15750; Thu, 27 Jan 2000 08:53:31 -0800 (PST) (envelope-from ru@ucb.crimea.ua) Received: (from ru@localhost) by relay.ucb.crimea.ua (8.9.3/8.9.3/UCB) id SAA86537; Thu, 27 Jan 2000 18:52:26 +0200 (EET) (envelope-from ru) Date: Thu, 27 Jan 2000 18:52:26 +0200 From: Ruslan Ermilov To: Sheldon Hearn Cc: Peter Wemm , current@FreeBSD.ORG Subject: Re: src/include/Makefile,v 1.109 is broken Message-ID: <20000127185226.A84871@relay.ucb.crimea.ua> Mail-Followup-To: Sheldon Hearn , Peter Wemm , current@FreeBSD.ORG References: <20000127170058.A57120@relay.ucb.crimea.ua> <24738.948990848@axl.noc.iafrica.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.3i In-Reply-To: <24738.948990848@axl.noc.iafrica.com>; from Sheldon Hearn on Thu, Jan 27, 2000 at 06:34:08PM +0200 X-Operating-System: FreeBSD 3.3-STABLE i386 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, Jan 27, 2000 at 06:34:08PM +0200, Sheldon Hearn wrote: > > > On Thu, 27 Jan 2000 17:00:58 +0200, Ruslan Ermilov wrote: > > > An attached patch seems to fix the problem. > > Does anybody actually understand what's really going on in this file? > Everyone uses the words "seems to" and "I think" when they're proposing > fixes in this file. > Disregard my "seems" word above, it really fixes the problem ;=) BTW, I has given a comment: | The idea was that `copies' should first undo all the | things `symlinks' did, but it is broken now. > I propose that we hold out for a fix which is accompanied by comments > that explain what the hell all these oddball variables are used for and > why SHARED is overridden (or used at all in the buildworld case). > Obviously, to speed up the building process. > Ruslan, if I misunderstood your words, please don't take offense. It's > just that this'll be the 5th commit in this regard without comment > from Marcel, who was responsible for rewriting most of this Makefile > recently. > I was told by Alexey Zelkin that Marcel was hired by some giant company, and he asked for FreeBSD vacation for some time (though I personally did not see such a message)... -- Ruslan Ermilov Sysadmin and DBA of the ru@ucb.crimea.ua United Commercial Bank, ru@FreeBSD.org FreeBSD committer, +380.652.247.647 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message