From owner-svn-ports-all@FreeBSD.ORG Tue Jun 24 11:39:56 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B9C7E206; Tue, 24 Jun 2014 11:39:56 +0000 (UTC) Received: from mail-yk0-x230.google.com (mail-yk0-x230.google.com [IPv6:2607:f8b0:4002:c07::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 403B52ECE; Tue, 24 Jun 2014 11:39:56 +0000 (UTC) Received: by mail-yk0-f176.google.com with SMTP id 131so76021ykp.21 for ; Tue, 24 Jun 2014 04:39:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=6l7eRp2ODWkX3pCGB9dQuw9MPMvaiR7Foaofw575b1g=; b=m/BaCtHvZj7ZmCExdm4+rBtLswHhLV5iqXuLJPYviofBD7KjeRCmX8/c8/aPqztEAW 47NwB6Vn64TaZu5Ya6gvCpQr7Rm3RIR8PMIIa2J2hpL0gQbJ1cHpfHZKXZBCMmYtuaZe iwuGi/prDsC0P/zlPs4Tc1oZnnnsUAllJDIP4PQie70+geo7sM5J6smjc7x53xvWiJcU s8VZq6vVfxAdUVS4mLzAXV5cNhR6inX4V3sWAPU6kZm1MmWkdU3nf6cJ9+LC47fj+5Fa 2P9/4TPgCsPSISAK1yYDHKJILs3aTFF217u1IGVIwDcWm24tywkt2AcrZVTYe1z4Bfqt YdoQ== MIME-Version: 1.0 X-Received: by 10.236.28.133 with SMTP id g5mr752244yha.46.1403609995202; Tue, 24 Jun 2014 04:39:55 -0700 (PDT) Sender: antoine.brodin.freebsd@gmail.com Received: by 10.170.50.80 with HTTP; Tue, 24 Jun 2014 04:39:55 -0700 (PDT) In-Reply-To: <20140624113632.GA21948@FreeBSD.org> References: <201406162246.s5GMklsu074568@svn.freebsd.org> <20140624111232.GA11118@FreeBSD.org> <20140624113632.GA21948@FreeBSD.org> Date: Tue, 24 Jun 2014 13:39:55 +0200 X-Google-Sender-Auth: vfZjsLOx0Tv6IGaNApG7dw0TDuU Message-ID: Subject: Re: svn commit: r358059 - head/audio/x11amp From: Antoine Brodin To: Alexey Dokuchaev Content-Type: text/plain; charset=UTF-8 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , Dmitry Marakasov , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jun 2014 11:39:56 -0000 On Tue, Jun 24, 2014 at 1:36 PM, Alexey Dokuchaev wrote: > On Tue, Jun 24, 2014 at 01:21:57PM +0200, Antoine Brodin wrote: >> On Tue, Jun 24, 2014 at 1:12 PM, Alexey Dokuchaev wrote: >> > On Mon, Jun 16, 2014 at 10:46:47PM +0000, Dmitry Marakasov wrote: >> >> New Revision: 358059 >> >> URL: http://svnweb.freebsd.org/changeset/ports/358059 >> >> QAT: https://qat.redports.org/buildarchive/r358059/ >> >> >> >> Log: >> >> - Switch to USES=libtool, drop .la files >> >> - Mark BROKEN, does not run (BROKENness is not related to libtool change) >> >> [...] >> >> +BROKEN= hangs at start with gtk and linker errors >> > >> > Looks like it you should've used IGNORE instead (run-time problem). >> >> No BROKEN is fine in this case. > > What does "hangs at start" mean? x11amp is invoked during the build for > some sanity testing? > > If the build goes fine (without error), it should be IGNORE, not BROKEN. I disagree, if a port build but doesn't run, it must not be hidden behind IGNORE and must be marked BROKEN. And I will deprecate it in 6 months! Bye bye! Antoine