From owner-freebsd-current@FreeBSD.ORG  Tue Jun 10 12:41:35 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C787E37B401; Tue, 10 Jun 2003 12:41:35 -0700 (PDT)
Received: from birch.ripe.net (birch.ripe.net [193.0.1.96])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6E13343FB1; Tue, 10 Jun 2003 12:41:34 -0700 (PDT)
	(envelope-from marks@ripe.net)
Received: from laptop.6bone.nl (cow.ripe.net [193.0.1.239])
	by birch.ripe.net (8.12.9/8.11.6) with SMTP id h5AJfWRS027193;
	Tue, 10 Jun 2003 21:41:33 +0200
Received: (nullmailer pid 11602 invoked by uid 1000);
	Tue, 10 Jun 2003 19:41:32 -0000
Date: Tue, 10 Jun 2003 21:41:32 +0200
From: Mark Santcroos <marks@ripe.net>
To: Orion Hodson <orion@freebsd.org>
Message-ID: <20030610194132.GA4287@laptop.6bone.nl>
References: <20030609035127.GA36909@laptop.6bone.nl>
	<200306101644.h5AGiawR066527@puma.icir.org>
	<20030610191504.GA8927@laptop.6bone.nl>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030610191504.GA8927@laptop.6bone.nl>
User-Agent: Mutt/1.4.1i
X-Handles: MS6-6BONE, MS18417-RIPE
cc: current@freebsd.org
Subject: Re: Correct PCI suspend and resume operations [ was Re: cirrus ich3
	doesn't work after suspend to disk ]
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Jun 2003 19:41:36 -0000

On Tue, Jun 10, 2003 at 09:15:05PM +0200, Mark Santcroos wrote:
> > AFAICT, we don't common code for handling this and maybe there should
> > be some rather than have each driver replicate this behaviour.
> 
> In general, that would of course be better. However, I don't know if the
> PCI layer (in this case) always knows enough.
> On the other side, if the device itself has to do some special things, the
> PCI layer could at least do the generic stuff.

To be more precise, the suspend function should know the powerstate it is
transitioning to. If it keeps context (D0-D2) it doesn't need to do much
special, if it will loose context (D3) it should save the state at
suspend, and restore the state at resume.

Mark

-- 
Mark Santcroos                    RIPE Network Coordination Centre
http://www.ripe.net/home/mark/    New Projects Group/TTM