From owner-freebsd-current@freebsd.org Sun Jul 15 17:44:30 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01C6B104866B for ; Sun, 15 Jul 2018 17:44:30 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7CEFE90631; Sun, 15 Jul 2018 17:44:29 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: by mail-it0-x241.google.com with SMTP id v71-v6so17973320itb.3; Sun, 15 Jul 2018 10:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0gzE8Xpbkd4B3CEowvZJQ6uftitCzna94IN9wQ1brRE=; b=a65sHbwYQsbZPAzrsGDNPOeLPNd9pHGRFbKIpGNprJUMgNPnPB9bU+QNxJmRxNnhfQ EFIiS8mOYjzYhVg4LqL7ViKNjjC1hiSwk545V2SJpfy1ziaZyLuqW1dWr0eCcojOvAeF Pj3QNJ2GapfhnyIpe9SjsRjfRdNtYmMnoLdR1Hz2w2UL1qI3PcAGgfEJLIkt5MKeA0ST PqVLHR5A1ofVGIMHlVR4x+mUvoFs5fyyArHGDa/eVtaZVKlgh+NR33PnpcAm6pNfoQJf 5RAs81hb+jvtV9a1VuyUlR9zbV0P9e+Dz3W84LqtC+1B/huAn0R3BrunmlXXcs2g2GkZ 8+oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0gzE8Xpbkd4B3CEowvZJQ6uftitCzna94IN9wQ1brRE=; b=KJ847HwYe5P7IYMUUwJ88k0fBu3KBxkdSADyyPdTLyHfdvwEOpKK71QSDPcTKsdBdh hXNRdmhIBL0QdsRgTYj+XQ+vovMuSTThqOb4hbQKzjpqMzCeJRJnAp7e9iNqbvjJymhL 2wTW3cXHJiSZJU5jMxio8hB9QBCAskOc1pkJhp8/UvJXymDj5uqeXwNltIaYcexDlsPn WBY6mWuh5+SNIx0XWX6Ixx4zcKTCt3Tisu24Gfyd2wT10rYEEtcrPrSntLjabo4xdzRL mPD8mdX2qKZmD9T0XJAKxKukst6Ctg9VUgBpJos21o85FxNe1DycOsjFbl6PGIbMPp0n WVjw== X-Gm-Message-State: AOUpUlE4ibBhYuCZjTkaaPkCEsonrO+gr2EVzXFL9XHMV5Fy0svAdpaO AxvDiAY96ldKbIvwePLWuBvC9+sR43UZDscNYTAAZg== X-Google-Smtp-Source: AAOMgpdnlh7Rb6BLWwznYiBNUzpUBVusaSqs2Q1xxaPtCUxtw+44d0W+Fd7QovpmhkxXp2YZwnZjAs/HmYMaUpnp/s0= X-Received: by 2002:a24:1dd6:: with SMTP id 205-v6mr10233139itj.132.1531676668625; Sun, 15 Jul 2018 10:44:28 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:8d2:0:0:0:0:0 with HTTP; Sun, 15 Jul 2018 10:44:28 -0700 (PDT) In-Reply-To: <20180715171737.GA31164@troutmask.apl.washington.edu> References: <20180715150638.GA30154@troutmask.apl.washington.edu> <1531674041.26036.1.camel@freebsd.org> <20180715171737.GA31164@troutmask.apl.washington.edu> From: Matthew Macy Date: Sun, 15 Jul 2018 10:44:28 -0700 Message-ID: Subject: Re: [PATCH] Recent libm additions To: sgk@troutmask.apl.washington.edu Cc: Ian Lepore , freebsd-current Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Sun, 15 Jul 2018 18:40:51 +0000 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 17:44:30 -0000 On Sun, Jul 15, 2018 at 10:17 AM, Steve Kargl wrote: > On Sun, Jul 15, 2018 at 11:00:41AM -0600, Ian Lepore wrote: >> On Sun, 2018-07-15 at 08:06 -0700, Steve Kargl wrote: >> > Index: ld80/e_powl.c >> > =================================================================== >> > --- ld80/e_powl.c (revision 336304) >> > +++ ld80/e_powl.c (working copy) >> > @@ -77,6 +77,7 @@ >> > #include >> > >> > #include "math_private.h" >> > +#include "polevll.c" >> >> If a file contains inline function definitions and is intended only to >> be included into another file and not compiled separately, shouldn't >> its name be spelled polevll.h ? >> > > Well, actually, the functions in polevll.c should have been copied > into ld80/e_powl.c, and polevall.c should never have been committed. > Unfortunately, the code was not reviewed for correctness. I've > made the minimum changes to address the two issues I've noted. > Feel free to either copy the functions and delete the polevall.c > or rename it. > In the bug report you cite, Chris Lattner states: "This is actually an unspecified feature of C99 (whether it supports the _Imaginary type). It is desirable to support this, but not a regression. I'm more than happy to commit these changes, but neither including a .c file nor compensating for the absence of a gcc feature in clang is a correctness fix. In the future you might wish to subscribe to phab reviews so that you can be notified when changes like this are under consideration. Thank you for your input. -M