From nobody Wed Jun 4 22:55:59 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bCNGp3kgWz5xlvn; Wed, 04 Jun 2025 22:56:02 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bCNGp2qGZz3gcn; Wed, 04 Jun 2025 22:56:02 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749077762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wSx8LC7eFzfWhwKYsUJW1BVMugGioFbrVZs0f+VKNUg=; b=ueItsHxDcLba9K39s1thlytBCpW089+L5siTB0MEJLKBVlXKOlWiZdZlYQpxOvza94AMBg NkUaQWLD8wGMuOiSPHPhULQAhGeCuYx5SCC7jdBqVqx5QnsCQTXCoX1oLMaSO2BZTDiGY2 c3OnZrmxrrmh5wTyOfE3AnSI7W+LRfiO05a5idB0CqGsJL8vLo3ccCeBHkrG2YAYJtYbOX f/L8pnHjNCwNlwiRNBzwzqi27ba4D9aP2JU8tXe2UcibMwvLTPMYQcYrSdGNm49GqkGNnM i90jCrnIUexsAUjQ00SqB4hdMqBzbjs/nTXzVxzX3jAOkElMsnn6S9IAkw4v7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749077762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wSx8LC7eFzfWhwKYsUJW1BVMugGioFbrVZs0f+VKNUg=; b=DNA+4gYPTTTC1U87sVUY4FaQ94kD9B9bnp8oBj1USBoWunsb84ibZ8+j0DyebIqguA6RCY kSYo26msNKYHnTnCj+hq4BOnyoiZp2Lo5ehLZxslXgEL2iOp0mZhBX1859SBkGLsoimizN +qEaFqcLdx1EPDVnpwhrqoNxwrkHzr/Kee3x1nT2/IBfdwAfSkkc/mh9+h6CN7wDS84sfp yV6ojQ7r0/o6nSk0xrYhZrqooeugf12dFj5DNtEz/OjgETxQajjckOw6HhDApI6rtOnIVQ n6o1WPpsjVqRkrKSVa1JjmHOr2iYKbtKDn41Y3HnEX0qMulnAwQZTFovGZF6TA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1749077762; a=rsa-sha256; cv=none; b=VzAfGUdBGpqxwOYMaN5tP02Iis5+APhTJJdiwd6GbXQ9lKgVQx2qVU9J3urXiWe119qDgQ aLUIAhkFxd9vlBk6lV8iZo3gA9NPNUucafTAcdXqrkZmguDuVXduX+p7kwOBvFeAPNCZMa 1+XTLxxP3HBMpA+po3Swya6KTE9gGnz+Uxim96FzHduE1lBX1G78VnE1iNRwiPxANCbvP7 NyOGT7F2AM+MHJdTH4DWgXOv4Xl1deCFodQWNmVInMIF6a8UDibbKTFPDFXwpr0BITt0/N QuKkxeFyIY+PkhFMmtWPdI9FzTq3baAkXIfk775oK0xwSKaA126AvR2IP9e6qg== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bCNGn39vHzmVc; Wed, 04 Jun 2025 22:56:01 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Wed, 4 Jun 2025 15:55:59 -0700 From: Gleb Smirnoff To: Kyle Evans , markj@freebsd.org Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 969f6380eb66 - main - kdump: nicer printing of kill(2) PID argument Message-ID: References: <202506040151.5541pESm016476@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202506040151.5541pESm016476@gitrepo.freebsd.org> On Wed, Jun 04, 2025 at 01:51:14AM +0000, Kyle Evans wrote: K> The branch main has been updated by kevans: K> K> URL: https://cgit.FreeBSD.org/src/commit/?id=969f6380eb66f809eed3e5c38b6021824a4cc2bf K> K> commit 969f6380eb66f809eed3e5c38b6021824a4cc2bf K> Author: Kyle Evans K> AuthorDate: 2025-06-04 01:51:06 +0000 K> Commit: Kyle Evans K> CommitDate: 2025-06-04 01:51:06 +0000 K> K> kdump: nicer printing of kill(2) PID argument K> K> Similar to wait*(), kill(2) operates on a pid that currently gets output K> as hex. Output it in decimal to make it a little easier to eyeball the K> pid we're signalling. K> K> Reviewed by: markj K> Differential Revision: https://reviews.freebsd.org/D50508 I didn't review if PIDs are always printed as decimals or not, but for the file descriptors it is a mix of hex and decimals. :( Usually I go with a sed script over kdump output to make it consistent. I think if we try to bring that to common format, that would leave some people unsatisfied regardless of our choice - all decimal or all hex. So, I would suggest to add a command line options that would force into all hex or all decimal. -- Gleb Smirnoff