From nobody Wed Jul 15 06:57:44 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h0Rnj29m2z6l0L0 for ; Wed, 15 Jul 2026 06:57:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h0Rnh6GPHz3vQm for ; Wed, 15 Jul 2026 06:57:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784098664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xeQ/Tu/H8YdxxbA/eQqydoUqohKMe+SajZrgKzf4IAQ=; b=BNfrkLTIU6OF0JLxfKHNj5SfjtAYv0lU3yWiSXInCUSRpphytD3bvQvEq8QQ6XdejLcgpF o0UrJWAQq2sPNOnqaaSop8iRgDn4AfydwoK/mG2WIAx8k6uE4QKF78rJtSFAB0Fn2+bzV7 2jPzcjs9/iCBduLCSHGJOmEB7UVAUUm4RiFG58pM8fQvkMikDCkVnJtoMQpOkfxBLSkQsM gFFu3PNQIfqccg6fIJc/Ccq6tP0DtBslZoYI3/etvCt/tokS8xMbwx/qnh2v6lROG8f1is 6b1OWDInVd45iN5QojWMGzbYj78ikpOllhnxcPdG2JKR0DBjk17SWvypwuC1KQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1784098664; a=rsa-sha256; cv=none; b=H4zI3AgIEkrkMBM9oUYpRwdOuqQJialGOj7jInpIIbzR3cQeyz6IM90WUNhNeSnqEBQW6U /kvNz5mSq+SV2vPCqQFh9onFiSuxL8xgw0sIBdTTMx5IG1upgyE9QxABfD3+npIePWtwhO CVp0/gCAlP1CbG6nRIaMLoRuDWzcdVlFFLvf+SLzZg+2hz/vwu37yty78KbwrjfyY2TM2y sk460KZAoiLUpKh+TYVCWww0jXajSTjkHjKiglEXMoJMcQ3onnt9xQqoFsCtbji9f/57B8 kDxp+D3BVt6CInCcia4tIqMXrtVQZeIeaEjzUAMJSL4dwtJBmQfbBdcJRDEmOw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784098664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xeQ/Tu/H8YdxxbA/eQqydoUqohKMe+SajZrgKzf4IAQ=; b=FkXsDw0qmvkKUzUJlkdM39Sk5lfTJZ+ciXgLnry51YJ34D14WQCWafchq5ioWUvTFWXFYc 5cpn3qPAjwxlPriFRkTQ0pibQ+AqVB2ifzTaodGnsbmfEdwTcSERXw6cJ+rlcTEQmD/fs9 yTQr4o2Wg4Shy7z4/bt8Ekk4FG2KEn4rUaOrx3Oihy58vtur1rnX3QYUJ4a8SEX1OEFbP5 xWO8mJ0eKL8/h/pRNno4WkqmXHuutESsdOedS5aQGuIt9Md4k6niwU/66IBuL6yMnTMaMA a0hlkPol3OA4jgCHA70jN8zsHTFrg7VfJOZL20WoOgiFtVQWe1/M1v2HA0z3cQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h0Rnh4K25z4yn for ; Wed, 15 Jul 2026 06:57:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3480f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 15 Jul 2026 06:57:44 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Faraz Vahedi From: Enji Cooper Subject: git: 5d0488b29dc5 - main - virtio: Report feature masks on negotiation failure List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5d0488b29dc5b3e8201d04cf7a015dce9e774d5d Auto-Submitted: auto-generated Date: Wed, 15 Jul 2026 06:57:44 +0000 Message-Id: <6a572f68.3480f.66cced96@gitrepo.freebsd.org> The branch main has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=5d0488b29dc5b3e8201d04cf7a015dce9e774d5d commit 5d0488b29dc5b3e8201d04cf7a015dce9e774d5d Author: Faraz Vahedi AuthorDate: 2026-07-09 20:01:20 +0000 Commit: Enji Cooper CommitDate: 2026-07-15 06:57:40 +0000 virtio: Report feature masks on negotiation failure Signed-off-by: Faraz Vahedi Reviewed-by: ngie Pull-Request: https://github.com/freebsd/freebsd-src/pull/2319 --- sys/dev/virtio/pci/virtio_pci_modern.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sys/dev/virtio/pci/virtio_pci_modern.c b/sys/dev/virtio/pci/virtio_pci_modern.c index bdd9cacd505e..4a4fedeb194d 100644 --- a/sys/dev/virtio/pci/virtio_pci_modern.c +++ b/sys/dev/virtio/pci/virtio_pci_modern.c @@ -464,7 +464,10 @@ vtpci_modern_finalize_features(device_t dev) status = vtpci_modern_get_status(sc); if ((status & VIRTIO_CONFIG_S_FEATURES_OK) == 0) { - device_printf(dev, "desired features were not accepted\n"); + device_printf(dev, "desired features were not accepted " + "(host %#jx, written %#jx)\n", + (uintmax_t)sc->vtpci_common.vtpci_host_features, + (uintmax_t)sc->vtpci_common.vtpci_features); return (ENOTSUP); }