From owner-freebsd-arch@freebsd.org Mon Mar 25 09:26:50 2019 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 13AFE155884A for ; Mon, 25 Mar 2019 09:26:50 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 5681688685 for ; Mon, 25 Mar 2019 09:26:49 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: by mailman.ysv.freebsd.org (Postfix) id 101681558844; Mon, 25 Mar 2019 09:26:49 +0000 (UTC) Delivered-To: arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F0187155883F; Mon, 25 Mar 2019 09:26:48 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AEBD788681; Mon, 25 Mar 2019 09:26:47 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x2P9QgaN078737; Mon, 25 Mar 2019 02:26:42 -0700 (PDT) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: (from freebsd-rwg@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x2P9QgYK078736; Mon, 25 Mar 2019 02:26:42 -0700 (PDT) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <201903250926.x2P9QgYK078736@gndrsh.dnsmgr.net> Subject: Re: Adding a new efi-update-loader script: need help understanding Makefile.inc1 for "make installworld" In-Reply-To: <20190324090103.GO1923@kib.kiev.ua> To: Konstantin Belousov Date: Mon, 25 Mar 2019 02:26:42 -0700 (PDT) CC: Rebecca Cran , FreeBSD Hackers , arch@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: AEBD788681 X-Spamd-Bar: ++ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [2.14 / 15.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-0.01)[-0.009,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[dnsmgr.net]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.50)[0.502,0]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.74)[0.739,0]; MX_GOOD(-0.01)[cached: gndrsh.dnsmgr.net]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.02)[ip: (0.08), ipnet: 69.59.192.0/19(0.04), asn: 13868(0.02), country: US(-0.07)] X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2019 09:26:50 -0000 > On Sat, Mar 23, 2019 at 08:21:43PM -0600, Rebecca Cran via freebsd-hackers wrote: > > I've been working on EFI support, and have a review > > (https://reviews.freebsd.org/D19588) to add a script, efi-update-loader, > > which will update the ESP containing the FreeBSD boot1.efi or loader.efi. > > > > I'd like to integrate it into the build system so it gets run when users > > do a "make installworld", but I'm lost looking through Makefile.inc1 - I > > have no clue where to add the code. > > > > Does anyone understand where and what to add? > > Can we take use of the opportunity and finally stop installing loader > at installworld target at all, please ? > > Add e.g. installloader target which would do whatever needed to loader. +1 boot code and loaders should always be seperated from the install target. Historically this was casued by the fact that the boot code and loader lived outside the file system and required operations beyond updating /usr/mdec (very ancient) or /boot/boot* (historical). Now that /boot/loader* is an immeditate effect on the bootability of the system it makes since to seperate this from the installworld target. -- Rod Grimes rgrimes@freebsd.org