From owner-freebsd-net@FreeBSD.ORG Sat Jul 19 02:06:24 2014 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EFCA7844; Sat, 19 Jul 2014 02:06:24 +0000 (UTC) Received: from mail-wi0-x22b.google.com (mail-wi0-x22b.google.com [IPv6:2a00:1450:400c:c05::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5CBB227EC; Sat, 19 Jul 2014 02:06:24 +0000 (UTC) Received: by mail-wi0-f171.google.com with SMTP id hi2so1680693wib.10 for ; Fri, 18 Jul 2014 19:06:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=XSIJg3/nRFJDGMbWLISWTRGC9h4+O32W0b+40fqgf1g=; b=w1a55eeur52wJUXMGz4nd474nIl1oFcXObgdcwBOsJ6q3krG/DisPap8zCqnti7i23 oXG8jODH7xeD0FA4YXcLPxBS7Z7BSbgyM2FJR8bM7lrCeKtFUVGqXlmc8fgV77gL5/bj ScUJ9/YOYNdQNmhAhuAIs7V8riMVXEbkkWjRyBA2DJFpEcOhQU35BKtHRIMH83NMpZWJ oZElvpUPk3Sb+hcfQH2FCO5c7ZifycsE6PoNIgEWyvL1o28zclP28xZwbb6cDKP9DG8s mzOSPUZnEjuzvzAi4JRAyqjatYIE2DtOGOIPwMJBuRtfX1QOahivOdZtsvjT/LIh7ejG OXEA== MIME-Version: 1.0 X-Received: by 10.194.158.226 with SMTP id wx2mr1490962wjb.107.1405735581697; Fri, 18 Jul 2014 19:06:21 -0700 (PDT) Received: by 10.216.190.194 with HTTP; Fri, 18 Jul 2014 19:06:21 -0700 (PDT) Reply-To: araujo@FreeBSD.org In-Reply-To: <53C964F7.8060503@gmail.com> References: <53C964F7.8060503@gmail.com> Date: Sat, 19 Jul 2014 10:06:21 +0800 Message-ID: Subject: Re: [patch][lagg] - Set a better granularity and distribution on roundrobin protocol. From: Marcelo Araujo To: Navdeep Parhar Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18 Cc: FreeBSD Net , Adrian Chadd X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jul 2014 02:06:25 -0000 2014-07-19 2:18 GMT+08:00 Navdeep Parhar : > On 07/18/14 00:49, Marcelo Araujo wrote: > > Hello guys, > > > > I made few changes on the lagg(4) patch. Also, I made tests using igb(4), > > ixgbe(4) and em(4); seems everything worked pretty well. > > > > I'm wondering if anyone else could make a review, and what I need to do, > to > > see this patch committed. > > Deliberately putting out-of-order packets on the wire is never a good > idea. This would count as a serious regression in lagg(4) imho. > > Regards, > Navdeep > > > I'm wondering if anyone have tested the patch; because as I have explained in another email, the number of SACK is much less with this patch. I have put some pcap files here: http://people.freebsd.org/~araujo/lagg/ Also, as far as I know, the current roundrobin implementation has no such kind of mechanism to control the order of the packages that goes to the wire. And this patch, what it only does is, instead to send only one package through one interface and switch to the another one, it will send X(where X is the number of packets defined via sysctl) packets and then, switch to the next interface. So, could you show me, where this patch deliberately put out-of-order packets? Did I miss anything? Best Regards, -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)