From owner-cvs-sys  Tue Oct 28 02:21:38 1997
Return-Path: <owner-cvs-sys>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id CAA12692
          for cvs-sys-outgoing; Tue, 28 Oct 1997 02:21:38 -0800 (PST)
          (envelope-from owner-cvs-sys)
Received: from plum.cyber.com.au (plum.cyber.com.au [203.7.155.24])
          by hub.freebsd.org (8.8.7/8.8.7) with SMTP id CAA12683;
          Tue, 28 Oct 1997 02:21:31 -0800 (PST)
          (envelope-from darrenr@cyber.com.au)
Received: (from darrenr@localhost) by plum.cyber.com.au (8.6.12/8.6.6) id VAA27329; Tue, 28 Oct 1997 21:21:25 +1100
From: Darren Reed <darrenr@cyber.com.au>
Message-Id: <199710281021.VAA27329@plum.cyber.com.au>
Subject: Re: cvs commit: src/sys/netinet ip_input.c
To: fenner@parc.xerox.com (Bill Fenner)
Date: Tue, 28 Oct 1997 21:21:24 +1100 (EST)
Cc: guido@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG,
        cvs-sys@FreeBSD.ORG
In-Reply-To: <97Oct27.204111pst.177487@crevenia.parc.xerox.com> from "Bill Fenner" at Oct 27, 97 08:41:04 pm
X-Mailer: ELM [version 2.4 PL23]
Content-Type: text
Sender: owner-cvs-sys@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

In some mail I received from Bill Fenner, sie wrote
[...]
> However, there is a problem with the actual change: the "goto" bypasses
> the strcpy() which gives log() something to print.  In addition, the whole
> log(LOG_WARNING, ...) for each packet provides a wonderful denial of service
> attack (I understand this isn't new with this commit, but it's still an
> issue).

At least log() is used and you have a chance to redirect it via syslogd(?) to
a file...if you relied on ipfw using printf, everything would go out via the
console.