From owner-freebsd-fs@FreeBSD.ORG Mon Jan 3 22:01:06 2011 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E678106566C for ; Mon, 3 Jan 2011 22:01:06 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id D7B5C8FC0C for ; Mon, 3 Jan 2011 22:01:05 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p03M12C9059689 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 4 Jan 2011 00:01:02 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id p03M11co005674; Tue, 4 Jan 2011 00:01:01 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id p03M11ca005673; Tue, 4 Jan 2011 00:01:01 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 4 Jan 2011 00:01:01 +0200 From: Kostik Belousov To: Rick Macklem Message-ID: <20110103220101.GH3140@deviant.kiev.zoral.com.ua> References: <991403850.53411.1294090462292.JavaMail.root@erie.cs.uoguelph.ca> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+QwZB9vYiNIzNXIj" Content-Disposition: inline In-Reply-To: <991403850.53411.1294090462292.JavaMail.root@erie.cs.uoguelph.ca> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_05, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-fs@freebsd.org Subject: Re: exporting non-mpsafe file systems - VFS_NEEDSGIANT() X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jan 2011 22:01:06 -0000 --+QwZB9vYiNIzNXIj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 03, 2011 at 04:34:22PM -0500, Rick Macklem wrote: > Hi, >=20 > The code currently in the experimental NFS server w.r.t. handling > VFS_LOCK_GIANT()/VFS_UNLOCK_GIANT() is currently BADLY broken. > Fortunately, since the major file systems being exported are mpsafe > and don't need Giant, nobody seems to be noticing. >=20 > Since the code is ugly and not easy to fix, I'd like to just delete > it and only allow mpsafe file systems to be exported. (I looked at > ufs/zfs/nullfs/msdosfs/cs9660 and they all appear to be mpsafe.) >=20 > So does anyone know of a non-mpsafe file system that needs to be > exported or see other serious problems w.r.t. not allowing exporting > of non-mpsafe file systems? The only sami-important fs that is not mpsafe is smbfs. I would say, go with the removal of VFS_LOCK_GIANT from the new nfs server. --+QwZB9vYiNIzNXIj Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk0iRx0ACgkQC3+MBN1Mb4j51QCghcRJbclbfQfKp/EYSlralTwx fRAAn3oK9sBvrSInJ2faqOmIsdIXuezU =lgZZ -----END PGP SIGNATURE----- --+QwZB9vYiNIzNXIj--