From owner-svn-src-head@freebsd.org  Sun Dec 27 17:10:45 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E608EA52D36
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Sun, 27 Dec 2015 17:10:45 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from erouter6.ore.mailhop.org (erouter6.ore.mailhop.org
 [54.187.213.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id CA44619AA
 for <svn-src-head@freebsd.org>; Sun, 27 Dec 2015 17:10:45 +0000 (UTC)
 (envelope-from ian@freebsd.org)
Received: from ilsoft.org (unknown [73.34.117.227])
 by outbound3.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA;
 Sun, 27 Dec 2015 17:10:02 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.14.9/8.14.9) with ESMTP id tBRHAbVv012229;
 Sun, 27 Dec 2015 10:10:37 -0700 (MST) (envelope-from ian@freebsd.org)
Message-ID: <1451236237.1369.9.camel@freebsd.org>
Subject: Re: svn commit: r292777 - in head: lib/libc/sys sys/kern
From: Ian Lepore <ian@freebsd.org>
To: Dmitry Chagin <dchagin@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Date: Sun, 27 Dec 2015 10:10:37 -0700
In-Reply-To: <201512271537.tBRFb7nN095297@repo.freebsd.org>
References: <201512271537.tBRFb7nN095297@repo.freebsd.org>
Content-Type: text/plain; charset="us-ascii"
X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Dec 2015 17:10:46 -0000

On Sun, 2015-12-27 at 15:37 +0000, Dmitry Chagin wrote:
> Author: dchagin
> Date: Sun Dec 27 15:37:07 2015
> New Revision: 292777
> URL: https://svnweb.freebsd.org/changeset/base/292777
> 
> Log:
>   Verify that tv_sec value specified in settimeofday() and
> clock_settime()
>   (CLOCK_REALTIME case) system calls is non negative.
>   This commit hides a kernel panic in atrtc_settime() as the
> clock_ts_to_ct()
>   does not properly convert negative tv_sec.
>   
>   ps. in my opinion clock_ts_to_ct() should be rewritten to properly
> handle
>   negative tv_sec values.
>   
>   Differential Revision:	https://reviews.freebsd.org/D4714
>   Reviewed by:		kib
>   
>   MFC after:	1 week

IMO, this change is completely unacceptable.  If there is a bug in
atrtc code, then by all means fix it, but preventing anyone from
setting valid time values on the system because one driver's code can't
handle it is just wrong.

-- Ian