From owner-svn-src-head@freebsd.org Thu Dec 31 01:08:58 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4853BA56428 for ; Thu, 31 Dec 2015 01:08:58 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-wm0-x22a.google.com (mail-wm0-x22a.google.com [IPv6:2a00:1450:400c:c09::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D57FD1F2F for ; Thu, 31 Dec 2015 01:08:57 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-wm0-x22a.google.com with SMTP id u188so54081769wmu.1 for ; Wed, 30 Dec 2015 17:08:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=486WYNOrelc+SUlWNAfyIMtwSPb6tgMYlStgZQFD7BM=; b=2SnK4BPXIXi8UMlGkCfArIdI4xvMLs2v77CLwwMReS4my+hpSanJCfC7uGxC7xl9A4 t7oQ6wB2ZxWULps5roTpDeVVQ/uRnYEONo5By7FGeJr3+SaRKoOnLnIqApyXNHn/e6Xq J64lcqrpKCMyXFMnWswe0B8KrpE96FLqzllm3SWT3t50vthJmFZ2B7mQVNWxbLJ+uq26 +q/FjBVlzPp2G7GgI/DeGMG9PZmF/BMjGJgU5aDJgyW/JpYnBb3oL99EiNXYa3MFthbR soLN1Ju8lkpemmlBjS9PYAj28fZR9NxJH1wWIaDpBoPR+ir/u6vAjv5QS9SYHvR+2w7m 096A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=486WYNOrelc+SUlWNAfyIMtwSPb6tgMYlStgZQFD7BM=; b=l55Rgp9PZdHF4mjRzFTSelZ8HZ3//4EM0rniOQpBpt76tTgfZNbZDiwHRCjgMpJepj mPr7YepquGGTr+mkwc5O/PfHtFzmJWp9sNQCepsFUnFAZ+Iz45RDMoDlGjj0SI21fd3P vtekJkocHX/COlz7km4y1xrPZiJdKxgwwuhqRtzt5zk7ogfW6jkffzGyp6ZCsyk7PUQX jrIwDqCZV2/YhzXpJQi9vC2WGpFPOawredi95trWqo+JCxhi39WDPJDp+fmkMtCPbpts Rt0OIsll2Qsrgho88f4KwnP9YdVp9YrqTu1C2IbknCZ63D0z9Pl0S04btBLBB6nD55rx j5WQ== X-Gm-Message-State: ALoCoQmW+tY36oP0E2mB8plWl3Rjh5TnCrnDqFs2b8mGVle1ErAoM3er3jMkXnb52AagE/mwbh68T3n6vzQMpj4ns3XqOU0y8jWtsz16cA5DK/yiFaUEWBE= MIME-Version: 1.0 X-Received: by 10.194.178.70 with SMTP id cw6mr72662380wjc.73.1451524135067; Wed, 30 Dec 2015 17:08:55 -0800 (PST) Received: by 10.194.85.167 with HTTP; Wed, 30 Dec 2015 17:08:54 -0800 (PST) In-Reply-To: <201512181633.tBIGXFff046683@repo.freebsd.org> References: <201512181633.tBIGXFff046683@repo.freebsd.org> Date: Thu, 31 Dec 2015 02:08:54 +0100 Message-ID: Subject: Re: svn commit: r292440 - in head/sys: kern sys From: Oliver Pinter To: Mateusz Guzik Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Dec 2015 01:08:58 -0000 On 12/18/15, Mateusz Guzik wrote: > Author: mjg > Date: Fri Dec 18 16:33:15 2015 > New Revision: 292440 > URL: https://svnweb.freebsd.org/changeset/base/292440 > > Log: > proc: fix a race which could result in dereference of bad p_pgrp pointer > on fork > > During fork p_starcopy - p_endcopy area of a process is populated with > bcopy > with only proc lock held. Another forking thread can find such a process > and > proceed to access p_pgrp included in said area. > > Fix the problem by moving the field outside. It is being properly > assigned > later. > > Reviewed by: kib > Diagnosed by: kib > Tested by: Fabian Keil > MFC after: 10 days Hi mjg@! Just an MFC reminder and question: This patch is still needs on 10-STABLE? > > Modified: > head/sys/kern/kern_proc.c > head/sys/sys/proc.h > > Modified: head/sys/kern/kern_proc.c >