From nobody Mon Sep 1 22:01:08 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cG2rN3nmmz65MYV; Mon, 01 Sep 2025 22:01:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cG2rN39Vmz3xGS; Mon, 01 Sep 2025 22:01:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756764068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+JgzIvTxk7bxuHg6YmntIfOoLYbVcpTRbCGcCMm7Tz0=; b=syAhiv+d95OWV4CMiXP/hVgeYVoLstUpFkioM5urRIMEIxCM/d9UB5lS9nI/0ft8Lyt+OP 9nviDMH1D83JHC0q1GC/42NcnNJ6RMHwMHERHfTf1QrlPOY1iWPffhtNiCmgJxZlZ118KM LQ7999zyD6wmAorYxJ0jOl4ll/CNhL+kl1pJD6gM13oxzuqK2Hn+L6pnB9H7r+yuYGYhL2 tWfbnPXrkIDcoyZd7ZaITy0uUSF3ZzSogyrYm3N0WO7o9APxr1ouXQzwmdmJPiHSYfTsQX mrD9ErPmj6dgja+pk9penpe6Frd/EuxrDDNqEKMObxJxRNav7c2IcQkhMED5CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756764068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+JgzIvTxk7bxuHg6YmntIfOoLYbVcpTRbCGcCMm7Tz0=; b=b4qK4X4rO13c7/bzht1aqwAEy7MVd+dlHXPaFlTjPv6XRByfc33VfZKYh+Ky/EcwjnmYop Bpny2m7YxIj4xJ9mI+YLf7R/h2Ktv/OYRT7byYrdfm/bfkaoeZBpqOPd51ifsspzx5NIw1 kQreg78n/IAJAL/uRHVgf91Otgthb8E64U7qvGJNshjutbYU3r4EBC8JfokUC6YAzNGVWv 89xZOds+kx0I1/MAwbI1rtPyxLCRIasTnSDdya6KWl82fyAITj5wHdZl+JtlJhOffHXI90 nj4lOvzU4nlp9DtD2Vc9LFkSfHv5F6AoicNk+IA1kXQKNoHr4sLl2ffUjVauRw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1756764068; a=rsa-sha256; cv=none; b=KceW+jZy3PcDhF+iw+wB5HKG2IsdO3Y3nvXuoArHmRF1m1pb2QYXy6iGjJGh2GauklkvIW OYPFr8/LmQYjM28d4cc+ibbIEkS/JZN45D/2re0HUMFihoqpWZeNsyNUCEDWUE4nlPjnhM Xv67Q4zaUZYInV2QXC2jRG1Np6ETfBSm4hWiQPz6ftWn/5a1Z4TVIl2w+BXS2TGt3ynRcV WufBk0jcikRxN0a0W8DgEk3MllIPvoyYfWtxV2188QcZMJhhW0DoV+6xuJ/oOo7FdUxNg4 pNOwXOoPV3HPh+vd4f9CALxG9rlOGHCAdG09kliaEZKe61z20dQ8YL6vFqDbPQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cG2rN2hJ0z3Rk; Mon, 01 Sep 2025 22:01:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 581M18FQ010671; Mon, 1 Sep 2025 22:01:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 581M18tv010659; Mon, 1 Sep 2025 22:01:08 GMT (envelope-from git) Date: Mon, 1 Sep 2025 22:01:08 GMT Message-Id: <202509012201.581M18tv010659@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: dfafdbdfc3e9 - main - stand: Use calloc instead of malloc for initialization of filesystem devsw List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: dfafdbdfc3e9db8b878283bcbef35f5d8d37dae8 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=dfafdbdfc3e9db8b878283bcbef35f5d8d37dae8 commit dfafdbdfc3e9db8b878283bcbef35f5d8d37dae8 Author: null AuthorDate: 2025-09-01 21:57:06 +0000 Commit: Warner Losh CommitDate: 2025-09-01 21:57:14 +0000 stand: Use calloc instead of malloc for initialization of filesystem devsw This change is required for https://reviews.freebsd.org/D49355, so that we can check if d_dev is uninitialized by checking if it's NULL. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D49705 --- stand/common/disk.c | 2 +- stand/kboot/kboot/hostdisk.c | 2 +- stand/libofw/devicename.c | 2 +- stand/libsa/dev.c | 2 +- stand/libsa/zfs/zfs.c | 2 +- stand/uboot/devicename.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/stand/common/disk.c b/stand/common/disk.c index c1650f0fa1ec..1baf91efaa49 100644 --- a/stand/common/disk.c +++ b/stand/common/disk.c @@ -468,7 +468,7 @@ disk_parsedev(struct devdesc **idev, const char *devspec, const char **path) if (*cp != '\0' && *cp != ':') return (EINVAL); - dev = malloc(sizeof(*dev)); + dev = calloc(sizeof(*dev), 1); if (dev == NULL) return (ENOMEM); dev->dd.d_unit = unit; diff --git a/stand/kboot/kboot/hostdisk.c b/stand/kboot/kboot/hostdisk.c index a9117d4c1c9d..fc98bf534519 100644 --- a/stand/kboot/kboot/hostdisk.c +++ b/stand/kboot/kboot/hostdisk.c @@ -465,7 +465,7 @@ hostdisk_parsedev(struct devdesc **idev, const char *devspec, const char **path) return (EINVAL); } free(fn); - dev = malloc(sizeof(*dev)); + dev = calloc(sizeof(*dev), 1); if (dev == NULL) return (ENOMEM); dev->d_unit = 0; diff --git a/stand/libofw/devicename.c b/stand/libofw/devicename.c index f6419632c6bc..46a9717fdda5 100644 --- a/stand/libofw/devicename.c +++ b/stand/libofw/devicename.c @@ -98,7 +98,7 @@ ofw_common_parsedev(struct devdesc **dev, const char *devspec, const char **path if (ofw_path_to_handle(devspec, ofwtype, &rem_path) == -1) return (ENOENT); - idev = malloc(sizeof(struct ofw_devdesc)); + idev = calloc(sizeof(struct ofw_devdesc), 1); if (idev == NULL) { printf("ofw_parsedev: malloc failed\n"); return (ENOMEM); diff --git a/stand/libsa/dev.c b/stand/libsa/dev.c index 1edc843d508c..4f6932e96c48 100644 --- a/stand/libsa/dev.c +++ b/stand/libsa/dev.c @@ -72,7 +72,7 @@ default_parsedev(struct devdesc **dev, const char *devspec, int unit, err; char *cp; - idev = malloc(sizeof(struct devdesc)); + idev = calloc(sizeof(struct devdesc), 1); if (idev == NULL) return (ENOMEM); diff --git a/stand/libsa/zfs/zfs.c b/stand/libsa/zfs/zfs.c index 70a102f6425d..2f7c1caaa4b5 100644 --- a/stand/libsa/zfs/zfs.c +++ b/stand/libsa/zfs/zfs.c @@ -1643,7 +1643,7 @@ zfs_parsedev(struct devdesc **idev, const char *devspec, const char **path) spa = spa_find_by_name(poolname); if (!spa) return (ENXIO); - dev = malloc(sizeof(*dev)); + dev = calloc(sizeof(*dev), 1); if (dev == NULL) return (ENOMEM); dev->pool_guid = spa->spa_guid; diff --git a/stand/uboot/devicename.c b/stand/uboot/devicename.c index 4ee9c7fd72c4..23670d7593a2 100644 --- a/stand/uboot/devicename.c +++ b/stand/uboot/devicename.c @@ -102,7 +102,7 @@ uboot_parsedev(struct uboot_devdesc **dev, const char *devspec, } if (dv == NULL) return(ENOENT); - idev = malloc(sizeof(struct uboot_devdesc)); + idev = calloc(sizeof(struct uboot_devdesc), 1); err = 0; np = (devspec + strlen(dv->dv_name));