From owner-svn-ports-all@FreeBSD.ORG Mon Oct 6 03:35:39 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 00620B75; Mon, 6 Oct 2014 03:35:38 +0000 (UTC) Received: from mail-oi0-x234.google.com (mail-oi0-x234.google.com [IPv6:2607:f8b0:4003:c06::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 98BB52EE; Mon, 6 Oct 2014 03:35:38 +0000 (UTC) Received: by mail-oi0-f52.google.com with SMTP id a3so3021160oib.39 for ; Sun, 05 Oct 2014 20:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=NdmnmfjmQtCfv/EzAEufWluYYKYiPmHUCUxGJTYivr4=; b=SlnjdkJmK7qypiJs/HjbKPWYLnRq9xej5yzKrjD5DGF//5qu0p6F0jYhFrJrhRotx2 pHeBM82xPrZY0sT85Qx40O7Re8csd8s+Pydc5UmBuwUoMgWWttd9oaMWrJZ7n+PR1v5b 1+Lo5HOTdtF81ytkLXS+LOa5e93RenX1mCx9KO0jsUQYSbiW1BjXgDgDS4fepi5ja7yd x5umwYpxO3jVwZzQTuC6OiKVCs0L7OKDfVK5ZprkY84jAAMlliP1COlFmbYx3F/+VLKk i6q1XT0jreyf62ObN5HKGPHynDPXnCk0VAe0UZ7kZK9SV6IIeXBmHCxVlbhbce/AMQQ8 Bh8Q== MIME-Version: 1.0 X-Received: by 10.60.121.33 with SMTP id lh1mr6497110oeb.59.1412566537835; Sun, 05 Oct 2014 20:35:37 -0700 (PDT) Sender: andrej.zverev@gmail.com Received: by 10.182.73.233 with HTTP; Sun, 5 Oct 2014 20:35:37 -0700 (PDT) In-Reply-To: <201410052140.s95LeUa9030114@svn.freebsd.org> References: <201410052140.s95LeUa9030114@svn.freebsd.org> Date: Mon, 6 Oct 2014 07:35:37 +0400 X-Google-Sender-Auth: dfZICkeJC4j5sEyc61J3SdrOodE Message-ID: Subject: Re: svn commit: r370131 - in head/net-mgmt: . nagios-check_dhcp.pl From: Andrej Zverev To: Bartek Rutkowski Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Oct 2014 03:35:39 -0000 Hi, Only few questions :-) 1. {LOCALBASE}/libexec/nagios/utils.pm:${PORTSDIR}/net-mgmt/nagios-plugins <- why don't use pkgname instead? 2. @${REINPLACE_CMD} -e "s,/usr/bin/perl,${PERL}," ${WRKSRC}/${PORTNAME} <- you can use USES=shebangfix P.S. Approved by: mentors (implicit) <- not sure about this they both did it, or only one of them and why don't write who they are? On Mon, Oct 6, 2014 at 1:40 AM, Bartek Rutkowski wrote: > Author: robak > Date: Sun Oct 5 21:40:29 2014 > New Revision: 370131 > URL: https://svnweb.freebsd.org/changeset/ports/370131 > QAT: https://qat.redports.org/buildarchive/r370131/ > > Log: > net-mgmt/nagios-check_dhcp.pl: NEW PORT - Nagios DHCP check plugin > > This plugin tests the availability of a given DHCP server using unicast > delivery. > > PR: 187623 > Submitted by: Lawrence Chen > Approved by: mentors (implicit) > > Added: > head/net-mgmt/nagios-check_dhcp.pl/ > head/net-mgmt/nagios-check_dhcp.pl/Makefile (contents, props changed) > head/net-mgmt/nagios-check_dhcp.pl/distinfo (contents, props changed) > head/net-mgmt/nagios-check_dhcp.pl/pkg-descr (contents, props changed) > Modified: > head/net-mgmt/Makefile > > Modified: head/net-mgmt/Makefile > > ============================================================================== > --- head/net-mgmt/Makefile Sun Oct 5 21:36:02 2014 (r370130) > +++ head/net-mgmt/Makefile Sun Oct 5 21:40:29 2014 (r370131) > @@ -108,6 +108,7 @@ > SUBDIR += nagios-check_bacula5 > SUBDIR += nagios-check_clamav > SUBDIR += nagios-check_cpu_usage > + SUBDIR += nagios-check_dhcp.pl > SUBDIR += nagios-check_email_delivery > SUBDIR += nagios-check_hdd_health > SUBDIR += nagios-check_hp_bladechassis > > Added: head/net-mgmt/nagios-check_dhcp.pl/Makefile > > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/net-mgmt/nagios-check_dhcp.pl/Makefile Sun Oct 5 21:40:29 2014 > (r370131) > @@ -0,0 +1,37 @@ > +# Created by: Lawrence Chen > +# $FreeBSD$ > + > +PORTNAME= check_dhcp.pl > +PORTVERSION= 0.1 > +CATEGORIES= net-mgmt > +MASTER_SITES= > http://exchange.nagios.org/components/com_mtree/attachment.php?link_id=1526&cf_id=24&dummy=/ > +PKGNAMEPREFIX= nagios- > +DISTNAME= ${PORTNAME} > +EXTRACT_SUFX= > + > +MAINTAINER= beastie@tardisi.com > +COMMENT= Check the availability of a DHCP server using unicast > delivery > + > +RUN_DEPENDS= ${LOCALBASE}/libexec/nagios/utils.pm:${PORTSDIR}/net-mgmt/nagios-plugins > \ > + p5-IO-Interface>=0:${PORTSDIR}/net/p5-IO-Interface \ > + p5-Net-DHCP-Watch>=0:${PORTSDIR}/net/p5-Net-DHCP-Watch > + > +USES= perl5 > +USE_PERL5= run > + > +PLIST_FILES= libexec/nagios/check_dhcp.pl > +NO_BUILD= yes > +NO_WRKSUBDIR= yes > + > +post-patch: > + @${REINPLACE_CMD} -e "s,/usr/bin/perl,${PERL}," > ${WRKSRC}/${PORTNAME} > + > +do-extract: > + @${MKDIR} ${WRKDIR} > + @${CP} ${DISTDIR}/${PORTNAME} ${WRKDIR}/ > + > +do-install: > + ${MKDIR} ${STAGEDIR}${PREFIX}/libexec/nagios > + ${INSTALL_SCRIPT} ${WRKSRC}/check_dhcp.pl > ${STAGEDIR}${PREFIX}/libexec/nagios/check_dhcp.pl > + > +.include > > Added: head/net-mgmt/nagios-check_dhcp.pl/distinfo > > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/net-mgmt/nagios-check_dhcp.pl/distinfo Sun Oct 5 21:40:29 2014 > (r370131) > @@ -0,0 +1,2 @@ > +SHA256 (check_dhcp.pl) = > 7aa6f26ae11f66e7b7a0100649a42fbd7179279a1bc2ff0305d633be59bcc87b > +SIZE (check_dhcp.pl) = 4171 > > Added: head/net-mgmt/nagios-check_dhcp.pl/pkg-descr > > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/net-mgmt/nagios-check_dhcp.pl/pkg-descr Sun Oct 5 > 21:40:29 2014 (r370131) > @@ -0,0 +1,4 @@ > +This plugin tests the availability of a given DHCP server using unicast > +delivery. > + > +WWW: http://exchange.nagios.org/ > >