From owner-freebsd-arch@FreeBSD.ORG Wed Sep 8 18:19:49 2010 Return-Path: Delivered-To: freebsd-arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 23EBB10656E5; Wed, 8 Sep 2010 18:19:49 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id DC26D8FC0A; Wed, 8 Sep 2010 18:19:48 +0000 (UTC) Received: from critter.freebsd.dk (critter.freebsd.dk [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id BB50C3F611; Wed, 8 Sep 2010 18:19:47 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.4/8.14.4) with ESMTP id o88IJlUT067572; Wed, 8 Sep 2010 18:19:47 GMT (envelope-from phk@critter.freebsd.dk) To: mdf@FreeBSD.org From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 08 Sep 2010 10:51:45 MST." Date: Wed, 08 Sep 2010 18:19:47 +0000 Message-ID: <67571.1283969987@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: FreeBSD Arch Subject: Re: Extending sbufs with a drain X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2010 18:19:49 -0000 In message , mdf@ FreeBSD.org writes: >> But I will always have this nagging doubt that we just added yet >> another deadbeat extension, rather than actually solve the >> actual problem. > >So just to clarify, what do you consider the actual problem? As I said: That we have worked around the problem rather than fixing it properly. I did a prototype somewhat along the lines of what you have done but abandonned it, because we would loose the printf argument checking that GCC provides. (See also the extensible userland printf I did). My main objection to your patches is that you exposes internals of sbufs for no good reason, if you fix that, along the lines we have discussed, I won't have that objection. Poul-Henning -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.