From owner-p4-projects@FreeBSD.ORG Wed May 9 16:14:56 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id B384C16A404; Wed, 9 May 2007 16:14:56 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8307616A407 for ; Wed, 9 May 2007 16:14:56 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mxout3.cac.washington.edu (mxout3.cac.washington.edu [140.142.32.166]) by mx1.freebsd.org (Postfix) with ESMTP id 5CA0213C46A for ; Wed, 9 May 2007 16:14:56 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from smtp.washington.edu (smtp.washington.edu [140.142.33.7] (may be forged)) by mxout3.cac.washington.edu (8.13.7+UW06.06/8.13.7+UW07.03) with ESMTP id l49GEt44018442 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 9 May 2007 09:14:55 -0700 X-Auth-Received: from [192.168.10.45] (c-67-187-164-17.hsd1.ca.comcast.net [67.187.164.17]) (authenticated authid=youshi10) by smtp.washington.edu (8.13.7+UW06.06/8.13.7+UW07.03) with ESMTP id l49GEsEl016789 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 9 May 2007 09:14:55 -0700 Message-ID: <4641F37D.50808@gmail.com> Date: Wed, 09 May 2007 09:14:53 -0700 From: Garrett Cooper User-Agent: Thunderbird 2.0.0.0 (Windows/20070326) MIME-Version: 1.0 To: Fredrik Lindberg References: <200705082229.l48MTrbh069129@repoman.freebsd.org> <20070509070626.GA41419@freebsd.org> <4641818B.4030507@FreeBSD.org> <20070509103404.D71759@fledge.watson.org> <464199D9.7020908@shapeshifter.se> <9bbcef730705090710h653dc15bjb7a1159484c1c48b@mail.gmail.com> <4641E19F.80809@shapeshifter.se> In-Reply-To: <4641E19F.80809@shapeshifter.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-PMX-Version: 5.3.1.294258, Antispam-Engine: 2.5.1.298604, Antispam-Data: 2007.5.9.85635 X-Uwash-Spam: Gauge=IIIIIII, Probability=7%, Report='FORGED_FROM_GMAIL 0.1, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FROM_GMAIL 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __SANE_MSGID 0, __USER_AGENT 0' Cc: Perforce Change Reviews , Ivan Voras Subject: Re: PERFORCE change 119527 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2007 16:14:57 -0000 Fredrik Lindberg wrote: > Ivan Voras wrote: >> On 09/05/07, Fredrik Lindberg wrote: >> >>> Ok, I'll take a look at the various queue.h shipped with the major BSDs, >>> and see if I can find a common subset that suits my needs (without too >>> many compromises) and based on the findings I'll reconsider my choice. >> >> I use sys/queue.h in my userland applications all the time, there's no >> problem there. >> > > And it works on {Net,Open}BSD?, I could swear that I've been bitten by > sys/queue.h in the past when moving stuff between FreeBSD and NetBSD. > Could have been those TAILQ-macros Robert Watson talked about though. > > Fredrik Lindberg It may work with programs under normal conditions but are the queues guaranteed to work with thread sychronization and other non-simple conditions? I'd think that the FreeBSD queue is closer to that. Plus the FreeBSD Queue's API is simple and the maintainer doesn't have to peruse another set of source looking for the required function / method they need. Furthermore, it's a requirement made by style(9) to use methods that aren't rolled by the implementor :). Just a few thoughts. -Garrett