From owner-freebsd-current@FreeBSD.ORG Thu May 29 21:53:21 2008 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4225B1065672 for ; Thu, 29 May 2008 21:53:21 +0000 (UTC) (envelope-from cokane@FreeBSD.org) Received: from hrndva-omtalb.mail.rr.com (hrndva-omtalb.mail.rr.com [71.74.56.124]) by mx1.freebsd.org (Postfix) with ESMTP id D444E8FC16 for ; Thu, 29 May 2008 21:53:20 +0000 (UTC) (envelope-from cokane@FreeBSD.org) Received: from orion.intree.net ([70.62.16.218]) by hrndva-omta06.mail.rr.com with ESMTP id <20080529215319.NCLQ9231.hrndva-omta06.mail.rr.com@orion.intree.net>; Thu, 29 May 2008 21:53:19 +0000 Received: from mail.cokane.org (unknown [172.31.0.6]) by orion.intree.net (Postfix) with ESMTP id B7060361C017; Thu, 29 May 2008 17:53:19 -0400 (EDT) Received: by mail.cokane.org (Postfix, from userid 103) id 9212516B55D; Thu, 29 May 2008 17:53:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.1.8-gr1 (2007-02-13) on discordia X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.8-gr1 Received: from [172.20.1.3] (erwin.int.cokane.org [172.20.1.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.cokane.org (Postfix) with ESMTP id 48C2816B55B; Thu, 29 May 2008 17:53:09 -0400 (EDT) From: Coleman Kane To: Andrew Thompson In-Reply-To: <20080529214604.GA68753@citylink.fud.org.nz> References: <1212093692.1681.8.camel@localhost> <20080529214604.GA68753@citylink.fud.org.nz> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-AEcBGubK0Qzz5e0QQ9Y+" Organization: FreeBSD Project Date: Thu, 29 May 2008 17:52:23 -0400 Message-Id: <1212097943.1681.12.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1.1 FreeBSD GNOME Team Port Cc: current@FreeBSD.org Subject: Re: ndis(4) patch to replace obsolete if_watchdog interface X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 May 2008 21:53:21 -0000 --=-AEcBGubK0Qzz5e0QQ9Y+ Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2008-05-29 at 14:46 -0700, Andrew Thompson wrote: > On Thu, May 29, 2008 at 04:41:32PM -0400, Coleman Kane wrote: > > Hi, > >=20 > > I just replaced the obsoleted if_watchdog interface in ndis(4) with a > > local implementation. This should remove the obnoxious warning message > > on device init. Anyone using -CURRENT with an ndis card, could you send > > me success/fails? > >=20 > > The patch is here: > > * http://people.freebsd.org/~cokane/patches/if_ndis-new_wd.patch >=20 >=20 > This works different to the rest of the network drivers. The existing > drivers use a callout tick that runs while the driver is up and an > integer counter. >=20 > if (x && --x =3D=3D 0) > ...timeout... >=20 > You arm the callout and stop it after each Tx, does this have any > perfornace impact? >=20 >=20 > Andrew You are probably right, I'll look into what I can do to re-work it here... I just ran through to perform a naive if_watchdog-->callout_* conversion on this really quickly. Using it, I don't see much of a performance impact. However, I am not using this on a server and CPUFREQ >> NETFREQ for me. --=20 Coleman Kane --=-AEcBGubK0Qzz5e0QQ9Y+ Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkg/JZUACgkQcMSxQcXat5dYcwCfdOaqhqQoWUxVjylXDuDUG6aA jXgAnA/KZxoAcUpBl4emiNweLzvZW36U =OZGY -----END PGP SIGNATURE----- --=-AEcBGubK0Qzz5e0QQ9Y+--