From owner-cvs-all@FreeBSD.ORG  Fri Apr  8 02:30:21 2011
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 2B7E810656D7; Fri,  8 Apr 2011 02:30:21 +0000 (UTC)
Date: Fri, 8 Apr 2011 02:30:21 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: bf1783@gmail.com
Message-ID: <20110408023021.GA47293@FreeBSD.org>
References: <201104072239.p37Md9oh031253@repoman.freebsd.org>
	<BANLkTikmUZsHNjw2Jpe8Y7v5CD6WkZGtoQ@mail.gmail.com>
	<20110408022459.GA40411@FreeBSD.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="EeQfGwPcQSOJBaQU"
Content-Disposition: inline
In-Reply-To: <20110408022459.GA40411@FreeBSD.org>
User-Agent: Mutt/1.4.2.1i
Cc: Rene Ladan <rene@freebsd.org>, cvs-ports@freebsd.org, cvs-all@freebsd.org,
	ports-committers@freebsd.org
Subject: Re: cvs commit: ports/www/chromium Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Apr 2011 02:30:21 -0000


--EeQfGwPcQSOJBaQU
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline

On Fri, Apr 08, 2011 at 02:24:59AM +0000, Alexey Dokuchaev wrote:
> I've been thinking about this as well.  However, instead of bringing back
> this OPTION, I'd suggest adding "|| defined(PACKAGE_BUILDING)" to that
> .if to ensure that packages are can be safely run on pre-SSE2 CPUs.

Diff attached, seems to DTRT.

./danfe

--EeQfGwPcQSOJBaQU
Content-Type: text/plain; charset=koi8-r
Content-Disposition: attachment; filename="pb.diff"

Index: Makefile
===================================================================
RCS file: /home/danfe/fbsd/FreeBSD-CVS/ports/www/chromium/Makefile,v
retrieving revision 1.19
diff -u -r1.19 Makefile
--- Makefile	7 Apr 2011 22:39:08 -0000	1.19
+++ Makefile	8 Apr 2011 02:26:26 -0000
@@ -92,7 +92,7 @@
 GYP_DEFINES+=	use_gconf=0
 .endif
 
-.if ! ${MACHINE_CPU:Msse2}
+.if ! ${MACHINE_CPU:Msse2} || defined(PACKAGE_BUILDING)
 GYP_DEFINES+=	disable_sse2=1
 .endif
 

--EeQfGwPcQSOJBaQU--